[28.x backport] Fix firewalld reload for per-endpoint rules#50506
Merged
[28.x backport] Fix firewalld reload for per-endpoint rules#50506
Conversation
Make sure iptables rules are restored properly once firewalld has deleted them. Signed-off-by: Rob Murray <rob.murray@docker.com> Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com> (cherry picked from commit 6d457d9) Signed-off-by: Rob Murray <rob.murray@docker.com>
Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com> (cherry picked from commit 0739307) Signed-off-by: Rob Murray <rob.murray@docker.com>
f2bda67 to
3e9ff78
Compare
corhere
approved these changes
Jul 24, 2025
akerouanton
approved these changes
Jul 24, 2025
This was referenced Jul 31, 2025
dnegreira
added a commit
to dnegreira/advisories
that referenced
this pull request
Sep 2, 2025
Update advisory for GHSA-mh63-6h87-95cp The dependency causing this CVE, golang-jwt/jwt v3.2.1, is brought in via the project's main go.mod. Due to functional changes required to move away from v3 to v4/v5, upstream maintainers are required to do the necessary changes to the project code in order to fix this vulnerability. Update advisory for GHSA-4vq8-7jfc-9cvp This vulnerability affects Docker Engine (Moby) versions <= 25.0.12 where firewalld reload removes Docker''''s iptables rules that isolate containers in different bridge networks. Upstream maintainers must cut a release with the fix. References: 25.x backport PR: moby/moby#50445 28.x backport PR: moby/moby#50506' Update advisory for CVE-2024-36623 This vulnerability is being detected erroneously since this issue has been fixed since docker 25.0.4 and we currently ship v25.0.8 Signed-off-by: David Negreira <david.negreira@chainguard.dev>
dnegreira
added a commit
to dnegreira/advisories
that referenced
this pull request
Sep 2, 2025
Update advisory for GHSA-mh63-6h87-95cp The dependency causing this CVE, golang-jwt/jwt v3.2.1, is brought in via the project's main go.mod. Due to functional changes required to move away from v3 to v4/v5, upstream maintainers are required to do the necessary changes to the project code in order to fix this vulnerability. Update advisory for GHSA-4vq8-7jfc-9cvp This vulnerability affects Docker Engine (Moby) versions <= 25.0.12 where firewalld reload removes Docker''''s iptables rules that isolate containers in different bridge networks. Upstream maintainers must cut a release with the fix. References: 25.x backport PR: moby/moby#50445 28.x backport PR: moby/moby#50506' Update advisory for CVE-2024-36623 This vulnerability is being detected erroneously since this issue has been fixed since docker 25.0.4 and we currently ship v25.0.8
github-merge-queue bot
pushed a commit
to wolfi-dev/advisories
that referenced
this pull request
Sep 2, 2025
Update advisory for GHSA-mh63-6h87-95cp The dependency causing this CVE, golang-jwt/jwt v3.2.1, is brought in via the project's main go.mod. Due to functional changes required to move away from v3 to v4/v5, upstream maintainers are required to do the necessary changes to the project code in order to fix this vulnerability. Update advisory for GHSA-4vq8-7jfc-9cvp This vulnerability affects Docker Engine (Moby) versions <= 25.0.12 where firewalld reload removes Docker''''s iptables rules that isolate containers in different bridge networks. Upstream maintainers must cut a release with the fix. References: 25.x backport PR: moby/moby#50445 28.x backport PR: moby/moby#50506' Update advisory for CVE-2024-36623 This vulnerability is being detected erroneously since this issue has been fixed since docker 25.0.4 and we currently ship v25.0.8 Signed-off-by: David Negreira <david.negreira@chainguard.dev>
This was referenced Jul 31, 2025
dnegreira
added a commit
to dnegreira/advisories
that referenced
this pull request
Sep 2, 2025
Update advisory for GHSA-mh63-6h87-95cp The dependency causing this CVE, golang-jwt/jwt v3.2.1, is brought in via the project's main go.mod. Due to functional changes required to move away from v3 to v4/v5, upstream maintainers are required to do the necessary changes to the project code in order to fix this vulnerability. Update advisory for GHSA-4vq8-7jfc-9cvp This vulnerability affects Docker Engine (Moby) versions <= 25.0.12 where firewalld reload removes Docker''''s iptables rules that isolate containers in different bridge networks. Upstream maintainers must cut a release with the fix. References: 25.x backport PR: moby/moby#50445 28.x backport PR: moby/moby#50506' Update advisory for CVE-2024-36623 This vulnerability is being detected erroneously since this issue has been fixed since docker 25.0.4 and we currently ship v25.0.8 Signed-off-by: David Negreira <david.negreira@chainguard.dev>
dnegreira
added a commit
to dnegreira/advisories
that referenced
this pull request
Sep 2, 2025
Update advisory for GHSA-mh63-6h87-95cp The dependency causing this CVE, golang-jwt/jwt v3.2.1, is brought in via the project's main go.mod. Due to functional changes required to move away from v3 to v4/v5, upstream maintainers are required to do the necessary changes to the project code in order to fix this vulnerability. Update advisory for GHSA-4vq8-7jfc-9cvp This vulnerability affects Docker Engine (Moby) versions <= 25.0.12 where firewalld reload removes Docker''''s iptables rules that isolate containers in different bridge networks. Upstream maintainers must cut a release with the fix. References: 25.x backport PR: moby/moby#50445 28.x backport PR: moby/moby#50506' Update advisory for CVE-2024-36623 This vulnerability is being detected erroneously since this issue has been fixed since docker 25.0.4 and we currently ship v25.0.8
github-merge-queue bot
pushed a commit
to wolfi-dev/advisories
that referenced
this pull request
Sep 2, 2025
Update advisory for GHSA-mh63-6h87-95cp The dependency causing this CVE, golang-jwt/jwt v3.2.1, is brought in via the project's main go.mod. Due to functional changes required to move away from v3 to v4/v5, upstream maintainers are required to do the necessary changes to the project code in order to fix this vulnerability. Update advisory for GHSA-4vq8-7jfc-9cvp This vulnerability affects Docker Engine (Moby) versions <= 25.0.12 where firewalld reload removes Docker''''s iptables rules that isolate containers in different bridge networks. Upstream maintainers must cut a release with the fix. References: 25.x backport PR: moby/moby#50445 28.x backport PR: moby/moby#50506' Update advisory for CVE-2024-36623 This vulnerability is being detected erroneously since this issue has been fixed since docker 25.0.4 and we currently ship v25.0.8 Signed-off-by: David Negreira <david.negreira@chainguard.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Make sure per-Endpoint rules are reapplied after a firewalld reload.
- How I did it
- How to verify it
- Human readable description for the release notes
- Replace per-endpoint iptables rules after a firewalld reload.- A picture of a cute animal (not mandatory but encouraged)