Split dockerd main command to package under daemon#50010
Merged
vvoland merged 3 commits intomoby:masterfrom Jun 26, 2025
Merged
Split dockerd main command to package under daemon#50010vvoland merged 3 commits intomoby:masterfrom
vvoland merged 3 commits intomoby:masterfrom
Conversation
9007216 to
f63c202
Compare
AkihiroSuda
approved these changes
May 16, 2025
thaJeztah
reviewed
May 16, 2025
| @@ -1,5 +1,5 @@ | |||
| //go:generate go-winres make --arch=386,amd64,arm,arm64 --in=../../cli/winresources/dockerd/winres.json --out=../../cli/winresources/dockerd/resource | |||
| //go:generate go-winres make --arch=386,amd64,arm,arm64 --in=../../../cli/winresources/dockerd/winres.json --out=../../../cli/winresources/dockerd/resource | |||
Member
There was a problem hiding this comment.
Reminds me we still need to move the remaining bits related to this, but I didn't manage to get that working yet; got confused by the various paths used;
Member
Author
There was a problem hiding this comment.
I don't have much idea exactly how this works, but this change should still work
17 tasks
f63c202 to
3ed07ca
Compare
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
Allows using daemon/internal packages when creating dockerd Signed-off-by: Derek McGowan <derek@mcg.dev>
3ed07ca to
33139da
Compare
vvoland
approved these changes
Jun 24, 2025
Member
Author
|
Can we get this one in to unblock the others for #49873 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #49873