Skip to content

WIP: move winresources into cmd package#46886

Closed
thaJeztah wants to merge 2 commits intomoby:masterfrom
thaJeztah:move_winresources
Closed

WIP: move winresources into cmd package#46886
thaJeztah wants to merge 2 commits intomoby:masterfrom
thaJeztah:move_winresources

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 4, 2023

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
Copy link
Member Author

thaJeztah commented Dec 4, 2023

Looks like I started working on this, but didn't finish; not sure what's remaining, so this likely fails 😂 🙈

@thaJeztah
Copy link
Member Author

thaJeztah commented Dec 4, 2023 

0.341 cmd/dockerd/genwinres_windows.go
0.342 2023/12/04 13:15:02 open ../winresources/docker.ico: no such file or directory
0.342 cmd/dockerd/genwinres_windows.go:1: running "go-winres": exit status 1

@thaJeztah thaJeztah force-pushed the move_winresources branch 2 times, most recently from eea31a3 to 2932d31 Compare January 30, 2024 17:13
@thaJeztah thaJeztah mentioned this pull request Jun 14, 2024
Closed
5 tasks
@thaJeztah thaJeztah force-pushed the move_winresources branch from 2932d31 to 6211aa0 Compare June 14, 2024 07:53
@thaJeztah thaJeztah mentioned this pull request Jun 14, 2024
Merged
@thaJeztah thaJeztah mentioned this pull request Aug 10, 2024
Merged
@thaJeztah thaJeztah force-pushed the move_winresources branch 2 times, most recently from c292629 to 74e0605 Compare August 12, 2024 08:12
@thaJeztah
WIP: move winresources into cmd package
5806450 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
testing
75311a8 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this pull request May 16, 2025
Merged
@thaJeztah thaJeztah mentioned this pull request Jun 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon Awaiting requested review from tianon tianon will be requested when the pull request is marked ready for review tianon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thaJeztah