Skip to content

vendor: golang.org/x/net v0.36.0#49581

Merged
thaJeztah merged 2 commits intomoby:masterfrom
vvoland:vendor-x-net
Mar 8, 2025
Merged

vendor: golang.org/x/net v0.36.0#49581
thaJeztah merged 2 commits intomoby:masterfrom
vvoland:vendor-x-net

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Mar 4, 2025

Note - we're not directly affected, and don't even vendor those code parts: https://cs.opensource.google/go/x/net/+/cde1dda944dcf6350753df966bb5bda87a544842

vendor: golang.org/x/net v0.36.0

full diff: golang/net@v0.35.0...v0.36.0

Version v0.36.0 of golang.org/x/net fixes a vulnerability in the
golang.org/x/net/proxy and golang.org/x/net/http/httpproxy packages
which could cause the proxy to be bypassed.

Matching of hosts against proxy patterns could improperly treat an IPv6
zone ID as a hostname component. For example, when the NO_PROXY
environment variable was set to "*.example.com", a request to
"[::1%25.example.com]:80` would incorrectly match and not be proxied.

Thanks to Juho Forsén of Mattermost for reporting this issue.

This is CVE-2025-22870 and Go issue https://go.dev/issue/71984.

@thaJeztah
Copy link
Member

This one can be rebased

vvoland added 2 commits March 7, 2025 18:27
full diff: golang/net@v0.33.0...v0.35.0

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
full diff: golang/net@v0.35.0...v0.36.0

Version v0.36.0 of golang.org/x/net fixes a vulnerability in the
golang.org/x/net/proxy and golang.org/x/net/http/httpproxy packages
which could cause the proxy to be bypassed.

Matching of hosts against proxy patterns could improperly treat an IPv6
zone ID as a hostname component. For example, when the NO_PROXY
environment variable was set to "*.example.com", a request to
"[::1%25.example.com]:80` would incorrectly match and not be proxied.

Thanks to Juho Forsén of Mattermost for reporting this issue.

This is CVE-2025-22870 and Go issue https://go.dev/issue/71984.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland marked this pull request as ready for review March 7, 2025 17:29
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit b4bdf12 into moby:master Mar 8, 2025
150 checks passed
@thaJeztah thaJeztah added this to the 28.0.2 milestone Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants