update minimum go version to go1.23#49541
Conversation
|
Interesting failure (on Linux / Ubuntu); |
|
Don't merge this one yet; we only need this if #49543 would fix an actual issue; it's quite likely that the CVEs fixed there are not affecting our code, and if they would show up only a false positive in security scanners. We would need this at some point, but could possibly do so in a v28.1.0 release, not necessarily v28.0.1 |
|
"Thanks Gobama" |
49b485c to
da3ca0b
Compare
|
FWIW, I reduced this to ONLY the The We need the |
|
As to "why this in a separate PR?" - that's mostly because I don't want such changes to be hidden in some "update some dependencies" PR; I prefer them to be very visible to make them stand out a bit more 😅 |
|
If maintaining the release branches wasn't hard enough, now for backports a toolchain upgrade will almost certainly be required. |
|
Is there an issue filled somewhere asking the project to reconsider these automated minimum version bumps? |
|
@tianon I haven't opened a ticket, but left comments on the related proposal; knowing the Go maintainer's usual flow, I expect a ticket to be closed with "likely reject"; their motivation was fuzzy at least; mostly "because it's easier to have a bot do it" and "who knows, we might want to use some cool new Go features" golang/go#69095 (comment) |
Go maintainers started to unconditionally update the minimum go version for golang.org/x/ dependencies to go1.23, which means that we'll no longer be able to support any version below that when updating those dependencies; > all: upgrade go directive to at least 1.23.0 [generated] > > By now Go 1.24.0 has been released, and Go 1.22 is no longer supported > per the Go Release Policy (https://go.dev/doc/devel/release#policy). > > For golang/go#69095. This updates our minimum version to go1.23, as we won't be able to maintain compatibility with older versions because of the above. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
da3ca0b to
6e8eb8a
Compare
tianon
left a comment
There was a problem hiding this comment.
LGTM, but "under protest" (of Go's weird decisions constantly forcing everyone to make bad compromises)
|
Thanks! Let me bring this one in, so that we can look at updating those dependencies. I'll also dust off the original changes to update the |
This was required as of moby v28: moby/moby#49541
…address already in use" reliably on docker v28 (#776) * Update docker client v26.1.5 -> v28.1.1 * Set a deterministic network interface name, and ensure we're the default gateway These options were introduced in v28. They are ignored by older Docker client versions. * Update go from `1.22` -> `1.23` This was required as of moby v28: moby/moby#49541 * Update types to new names/locations for docker v28 * Downgrade docker to work with more installations: * Reapply v28.0.4 since we need priority? * Remove needless config; this will break homerunner * Include alias again for fed tests --------- Co-authored-by: Kegan Dougal <7190048+kegsay@users.noreply.github.com>
…address already in use" reliably on docker v28 (matrix-org#776) * Update docker client v26.1.5 -> v28.1.1 * Set a deterministic network interface name, and ensure we're the default gateway These options were introduced in v28. They are ignored by older Docker client versions. * Update go from `1.22` -> `1.23` This was required as of moby v28: moby/moby#49541 * Update types to new names/locations for docker v28 * Downgrade docker to work with more installations: * Reapply v28.0.4 since we need priority? * Remove needless config; this will break homerunner * Include alias again for fed tests --------- Co-authored-by: Kegan Dougal <7190048+kegsay@users.noreply.github.com>
Go maintainers started to unconditionally update the minimum go version for golang.org/x/ dependencies to go1.23, which means that we'll no longer be able to support any version below that when updating those dependencies;
This updates our minimum version to go1.23, as we won't be able to maintain compatibility with older versions because of the above.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)