cli/debug: move to "cmd/dockerd/debug"#47981
Conversation
Signed-off-by: Gabriel Tomitsuka <gabriel@tomitsuka.com>
|
@gtomitsuka Thank you!! If you're interested; I once did a very brief attempt at moving the remaining My draft PR with that first attempt is #46886 (I just rebased it); feel free to take that branch if you're interested on working on that (and if my branch is useful 😄). |
|
@thaJeztah thanks for rebasing, I'll look into it this weekend! |
|
Thanks! And don't feel "required" to do so, but it's just one of those patches that are in the back of my head and "I need to spend some time making it work". In all honesty, I'm not too familiar with that code, so I would have to do some digging (and your guess is probably as good as mine!). I can list some quick thoughts;
@crazy-max did some of the work on these, and if needed may be able to provide more input 🙈 (sorry for the ping, Kevin!) |
Description
The "cli/debug" package is a leftover from when the "docker" and "dockerd" cli were both maintained in this repository, and finding a more appropriate home for it has been a roadmap task since "docker/cli" was moved to its own repo – see #44641.
Currently, the primary user is "cmd/dockerd". Accordingly, I made it a subpackage of "cmd/dockerd" – "cmd/dockerd/debug".
In particular, I tried to match styles with "cmd/dockerd/trap", the other subpackage of "cmd/dockerd". Both packages are also imported by the "daemon" package.
Since it's binary-related and not library code, this shouldn't impact any external packages (all known importers on pkg.go.dev are moby forks).
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
It's Juicy's world, we're just living in it.
