Skip to content

Dockerfile: update containerd binary to v1.7.17 (static binaries and CI only) #47840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thaJeztah merged 2 commits into from
May 21, 2024
Merged

Dockerfile: update containerd binary to v1.7.17 (static binaries and CI only) #47840

thaJeztah merged 2 commits into from
May 21, 2024

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented May 17, 2024 •
edited
Loading

Update the containerd binary that's used in CI and static binaries

Update containerd (static binaries only) to [v1.7.17](https://github.com/containerd/containerd/releases/tag/v1.7.17)

Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com

@vvoland vvoland added this to the 27.0.0 milestone May 17, 2024
@vvoland vvoland self-assigned this May 17, 2024
@vvoland vvoland requested a review from tianon as a code owner May 17, 2024 08:45
@vvoland vvoland mentioned this pull request May 17, 2024
Merged
@vvoland
Dockerfile: update containerd binary to v1.7.17 (static binaries and …
4f0cb7d 
…CI only)

Update the containerd binary that's used in CI and static binaries

- full diff: containerd/containerd@v1.7.15...v1.7.17
- release notes: https://github.com/containerd/containerd/releases/tag/v1.7.17

```markdown changelog
Update containerd (static binaries only) to [v1.7.17](https://github.com/containerd/containerd/releases/tag/v1.7.17)
```

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland force-pushed the update-containerd branch from 70a641b to 4f0cb7d Compare May 17, 2024 09:07
@vvoland vvoland changed the title Dockerfile: update containerd binary to v1.7.16 (static binaries and CI only) Dockerfile: update containerd binary to v1.7.17 (static binaries and CI only) May 17, 2024
@thaJeztah
Copy link
Member

thaJeztah commented May 21, 2024

This one continues to be flaky. Is that actually related to containerd's shange to use blocksize?;

=== Failed
=== FAIL: amd64.integration.system TestDiskUsage/empty (0.00s)
    disk_usage_test.go:43: assertion failed: 
        --- du
        +++ →
          types.DiskUsage{
        - 	LayersSize: 4096,
        + 	LayersSize: 0,
          	Images:     {},
          	Containers: {},
          	... // 3 identical fields
          }
        
    --- FAIL: TestDiskUsage/empty (0.00s)

=== FAIL: amd64.integration.system TestDiskUsage (2.77s)

@vvoland
Copy link
Contributor Author

vvoland commented May 21, 2024 •
edited
Loading

Yeah I think it's related. That would solve the flakiness of this test, as now the behavior seems to be consistent 😅

EDIT: Oh, that change wasn't a recent one..

@thaJeztah
Copy link
Member

thaJeztah commented May 21, 2024

Yes, I also went looking, and that change in continuity already was merged a long time ago (v0.1.0 even?), so curious why it starts to fail more often.

@vvoland
integration/TestDiskUsage: Make 4096 also a 'empty' value
3847da3 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
thaJeztah
thaJeztah approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 8470add into moby:master May 21, 2024
@austinvazquez austinvazquez mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@tianon tianon Awaiting requested review from tianon tianon is a code owner

Assignees

@vvoland vvoland

Labels

area/dependencies impact/changelog process/cherry-picked status/2-code-review

Projects

None yet

Milestone

27.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@vvoland @thaJeztah