Fix usage calculation to account for sparse files #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek McGowan <derek@mcg.dev>
The current usage calculation does not account for usage within spares files. To correctly account for the usage, the number of blocks must be used rather than the reported file size. Signed-off-by: Derek McGowan <derek@mcg.dev>
d863222 to
bc5e3ed
Compare
Member
|
@chris-crone you love storage; perhaps you want to review as well? |
Member
|
LGTM |
chris-crone
reviewed
Nov 19, 2020
chris-crone
left a comment
There was a problem hiding this comment.
This makes sense to me but I don't know the code well enough to give a proper review :)
Contributor
|
I mean, no value is really correct with COW filesystems, tail packing, etc. What is the issue that this is trying to fix (I was told there was one). |
Member
Author
|
@justincormack this messes up ephemeral storage accounting in k8s when there are sparse files |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current usage calculation does not correctly account for usage within spares files. To correctly account for the usage, the number of blocks must be used rather than the reported file size.