Skip to content

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Apr 22, 2024

Don't fail-fast when encountering an image that targets an unexpected descriptor (neither a manifest nor index). Log a warning instead.

- How to verify it
TestImageList

- Description for the changelog

containerd image store: Fix `docker images` failing when any image in the store has unexpected target

- A picture of a cute animal (not mandatory but encouraged)

Don't fail-fast when encountering an image that targets an unexpected
descriptor (neither a manifest nor index). Log a warning instead.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland added kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. impact/changelog area/images Image Distribution containerd-integration Issues and PRs related to containerd integration labels Apr 22, 2024
@vvoland vvoland added this to the 26.1.0 milestone Apr 22, 2024
@vvoland vvoland self-assigned this Apr 22, 2024
@vvoland vvoland requested review from rumpl and thaJeztah April 22, 2024 11:06
@neersighted neersighted requested a review from cpuguy83 April 22, 2024 12:59
@cpuguy83 cpuguy83 merged commit c8af8eb into moby:master Apr 22, 2024
@cpuguy83
Copy link
Member

The only problem here is we don't have a way to surface this to the user.

@cpuguy83
Copy link
Member

But I agree that erroring out the whole list is not great either.

renovate bot added a commit to earthly/dind that referenced this pull request Apr 29, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker/docker](https://togithub.com/docker/docker) | minor | `26.0.2`
-> `26.1.0` |

---

### Release Notes

<details>
<summary>docker/docker (docker/docker)</summary>

### [`v26.1.0`](https://togithub.com/moby/moby/releases/tag/v26.1.0)

[Compare
Source](https://togithub.com/docker/docker/compare/v26.0.2...v26.1.0)

#### 26.1.0

For a full list of pull requests and changes in this release, refer to
the relevant GitHub milestones:

- [docker/cli, 26.1.0
milestone](https://togithub.com/docker/cli/issues?q=is%3Aclosed+milestone%3A26.1.0)
- [moby/moby, 26.1.0
milestone](https://togithub.com/moby/moby/issues?q=is%3Aclosed+milestone%3A26.1.0)
- Deprecated and removed features, see [Deprecated
Features](https://togithub.com/docker/cli/blob/v26.1.0/docs/deprecated.md).
- Changes to the Engine API, see [API version
history](https://togithub.com/moby/moby/blob/v26.1.0/docs/api/version-history.md).

##### New

- Add configurable OpenTelemetry utilities and basic instrumentation to
commands.
For more information, see [OpenTelemetry for the Docker
CLI](https://docs.docker.com/config/otel).
[docker/cli#4889](https://togithub.com/docker/cli/pull/4889)

##### Bug fixes and enhancements

- Native Windows containers are configured with an internal DNS server
for container name resolution, and external DNS servers for other
lookups. Not all resolvers, including `nslookup`, fall back to the
external resolvers when they get a `SERVFAIL` answer from the internal
server. So, the internal DNS server can now be configured to forward
requests to the external resolvers, by setting `"features":
{"windows-dns-proxy": true }` in the `daemon.json` file.
[moby/moby#47584](https://togithub.com/moby/moby/pull/47584)

> \[!NOTE]
> This will be the new default behavior in Docker Engine 27.0.

> \[!WARNING]
> The `windows-dns-proxy` feature flag will be removed in a future
release.

- Swarm: Fix `Subpath` not being passed to the container config.
[moby/moby#47711](https://togithub.com/moby/moby/pull/47711)
- Classic builder: Fix cache miss on `WORKDIR <directory>/` build step
(directory with a trailing slash).
[moby/moby#47723](https://togithub.com/moby/moby/pull/47723)
- containerd image store: Fix `docker images` failing when any image in
the store has unexpected target.
[moby/moby#47738](https://togithub.com/moby/moby/pull/47738)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6am on monday" (UTC), Automerge
- At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/earthly/dind).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: idodod <ido@earthly.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/images Image Distribution containerd-integration Issues and PRs related to containerd integration impact/changelog kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. status/2-code-review

Projects

Development

Successfully merging this pull request may close these issues.

4 participants