Skip to content

[23.0] Vendor rootlesskit v2#47258

Closed
aepifanov wants to merge 8 commits intomoby:23.0from
aepifanov:vendor_rootlesskit-v2
Closed

[23.0] Vendor rootlesskit v2#47258
aepifanov wants to merge 8 commits intomoby:23.0from
aepifanov:vendor_rootlesskit-v2

Conversation

@aepifanov
Copy link
Contributor

Vendor rootlesskit v2 and all dependencies

full diff: https://github.com/gotestyourself/gotest.tools/compare/v3.5.0..v3.5.1

Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com>
full diff: golang/crypto@v0.13.0...v0.18.0

Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com>
full diff: https://github.com/sirupsen/logrus/compare/v1.9.0..v1.9.3

Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com>
full diff: https://github.com/google/go-cmp/compare/v0.5.9..v0.6.0

Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com>
full diff: https://github.com/google/uuid/compare/v1.3.0..v1.5.0

Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com>
full diff: https://github.com/gorilla/mux/compare/v1.8.0..v1.8.1

Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com>
@AkihiroSuda AkihiroSuda added the area/rootless Rootless Mode label Jan 31, 2024
@thaJeztah thaJeztah changed the title Vendor rootlesskit v2 [23.0] Vendor rootlesskit v2 Jan 31, 2024
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this intended for the 23.0 branch?

Copy link
Contributor

@corhere corhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is intended for v23

@aepifanov aepifanov requested a review from thaJeztah January 31, 2024 16:01
@thaJeztah
Copy link
Member

🤦 looked from my phone and didn't consider who opened the PR. Do we need similar backports for 24 and 25? Otherwise newer versions use an older version of rootlesskit?

@aepifanov
Copy link
Contributor Author

🤦 looked from my phone and didn't consider who opened the PR. Do we need similar backports for 24 and 25? Otherwise newer versions use an older version of rootlesskit?

Sure, I'll take care about it

@thaJeztah
Copy link
Member

Also heads-up that there was a regression in v2.0.0; we merged a follow-up that updates it to v2.0.1;

@corhere
Copy link
Contributor

corhere commented Feb 6, 2024

I think we should hold off until #47248 is resolved as I suspect it is also a rootlesskit/v2 regression

@thaJeztah thaJeztah added this to the 23.0.10 milestone Mar 6, 2024
@AkihiroSuda
Copy link
Member

AkihiroSuda commented Mar 14, 2024

I think we should hold off until #47248 is resolved as I suspect it is also a rootlesskit/v2 regression

Being fixed in:

This was not a regression in rootlesskit v2, but rather related to changing the state dir from /tmp/... to /run/....

@corhere corhere modified the milestones: 23.0.10, 23.0.11 Mar 21, 2024
@corhere corhere modified the milestones: 23.0.11, 23.0.12 May 6, 2024
@corhere corhere modified the milestones: 23.0.12, 23.0.13 May 29, 2024
@corhere corhere modified the milestones: 23.0.13, 23.0.14 Jun 20, 2024
@corhere corhere removed this from the 23.0.14 milestone Aug 19, 2024
@corhere corhere added this to the 23.0.15 milestone Aug 19, 2024
@corhere corhere modified the milestones: 23.0.15, 23.0.16 Oct 7, 2024
@corhere corhere modified the milestones: 23.0.16, 23.0.17 Dec 5, 2024
@aepifanov aepifanov closed this Mar 19, 2025
@aepifanov aepifanov deleted the vendor_rootlesskit-v2 branch March 19, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/rootless Rootless Mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants