Skip to content

Update Rootlesskit to v2.0.1#47332

Merged
thaJeztah merged 3 commits intomoby:masterfrom
AkihiroSuda:rootlesskit-2.0.1
Feb 6, 2024
Merged

Update Rootlesskit to v2.0.1#47332
thaJeztah merged 3 commits intomoby:masterfrom
AkihiroSuda:rootlesskit-2.0.1

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Feb 6, 2024

- What I did

Fix:

- How I did it

Updated Rootlesskit to v2.0.1
https://github.com/rootless-containers/rootlesskit/releases/tag/v2.0.1

- How to verify it

Run DOCKERD_ROOTLESS_ROOTLESSKIT_NET=lxc-user-nic dockerd-rootless.sh, and verify that DNS works (e.g., docker --context=rootless pull hello-world)

- Description for the changelog

Update Rootlesskit to v2.0.1

- A picture of a cute animal (not mandatory but encouraged)
🐧

https://github.com/google/uuid/releases/tag/v1.6.0

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
https://github.com/rootless-containers/rootlesskit/releases/tag/v2.0.1

Fix issue 47327 (`rootless lxc-user-nic: /etc/resolv.conf missing ip`)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@thaJeztah
Copy link
Member

Failure is unrelated, and is a known flaky; I kicked GHA again

=== Failed
=== FAIL: amd64.integration.daemon TestLiveRestore/volume_references/local_volume_with_mount_options (2.32s)
    daemon_test.go:581: assertion failed: error is not nil: Error response from daemon: remove test-live-restore-volume-references-local: volume has active mounts
        --- FAIL: TestLiveRestore/volume_references/local_volume_with_mount_options (2.32s)

=== FAIL: amd64.integration.daemon TestLiveRestore/volume_references (20.77s)
    --- FAIL: TestLiveRestore/volume_references (20.77s)

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Prepared a cherry-pick (only the binary, as it looks like we don't need the vendor update);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v25 regression] rootless lxc-user-nic: /etc/resolv.conf missing ip

2 participants