Skip to content

internal: Add compatcontext.WithoutCancel#46552

Merged
vvoland merged 1 commit intomoby:masterfrom
vvoland:internal-compatcontext
Sep 27, 2023
Merged

internal: Add compatcontext.WithoutCancel#46552
vvoland merged 1 commit intomoby:masterfrom
vvoland:internal-compatcontext

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Sep 27, 2023

Copy the implementation of context.WithoutCancel introduced in Go 1.21 to be able to use it when building with older versions. This will use the stdlib directly when building with Go 1.21+.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Copy the implementation of `context.WithoutCancel` introduced in Go 1.21
to be able to use it when building with older versions.
This will use the stdlib directly when building with Go 1.21+.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland added status/2-code-review kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. labels Sep 27, 2023
@vvoland vvoland added this to the 25.0.0 milestone Sep 27, 2023
Copy link
Member

@akerouanton akerouanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. process/cherry-picked status/4-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants