Skip to content

Plumb context through info endpoint#46444

Merged
vvoland merged 1 commit intomoby:masterfrom
cpuguy83:docker_info_slow
Nov 20, 2023
Merged

Plumb context through info endpoint#46444
vvoland merged 1 commit intomoby:masterfrom
cpuguy83:docker_info_slow

Conversation

@cpuguy83
Copy link
Member

I was trying to find out why docker info was sometimes slow so plumbing a context through to propagate trace data through.

@cpuguy83 cpuguy83 force-pushed the docker_info_slow branch 5 times, most recently from 39d385b to 1571255 Compare September 10, 2023 18:33
@cpuguy83 cpuguy83 force-pushed the docker_info_slow branch 3 times, most recently from 5efd964 to b0fc5d4 Compare September 12, 2023 16:06
@cpuguy83 cpuguy83 force-pushed the docker_info_slow branch 2 times, most recently from c2507a0 to a53d3cd Compare September 13, 2023 16:01
@thaJeztah thaJeztah added status/2-code-review kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. area/daemon Core Engine labels Sep 13, 2023
@thaJeztah
Copy link
Member

@vvoland if you have time to give this one another look ❤️

@cpuguy83 cpuguy83 force-pushed the docker_info_slow branch 5 times, most recently from e622965 to 7189798 Compare October 1, 2023 17:38
@cpuguy83 cpuguy83 force-pushed the docker_info_slow branch 2 times, most recently from 6cda16e to b9adf03 Compare November 10, 2023 00:50
@cpuguy83
Copy link
Member Author

Rebased and all green.

I was trying to find out why `docker info` was sometimes slow so
plumbing a context through to propagate trace data through.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvoland vvoland merged commit d154421 into moby:master Nov 20, 2023
@thaJeztah thaJeztah added this to the 25.0.0 milestone Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/daemon Core Engine kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants