daemon: strongly type containerd log.OutputFormat#46525
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 21, 2023
Merged
daemon: strongly type containerd log.OutputFormat#46525thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
This type was introduced in containerd/containerd@0a79e67 Make use of it throughout our log-format handling code, and convert back to a string before we pass it to the containerd client. Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
25b4b52 to
0e80073
Compare
dmcgowan
approved these changes
Sep 21, 2023
Member
Author
|
FWIW, I'm good with this change, but not strongly attached either way; leaving the opportunity for @corhere to give his 👍 or 👎 (don't think this change is time sensitive either, so no rush) |
corhere
approved these changes
Sep 21, 2023
This was referenced Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For context: in #46489 I didn't want to change the type of
CommonConfig.LogFormat(daemon/config/config.go). And in #45966 (comment) I suggested to move this to a separate PR; both for visibility and for discussion (whether we want our daemon's Config struct to have a direct dependency on containerd/log's types.This type was introduced in
containerd/containerd@0a79e67
- A picture of a cute animal (not mandatory but encouraged)