remove more direct uses of logrus#46489
Conversation
072887a to
ba2853c
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ba2853c to
bd523ab
Compare
|
@neersighted ptal - was not directly considering backporting this part (hence keeping it separate), but it's still possible if we want to at some point. |
neersighted
left a comment
There was a problem hiding this comment.
LGTM; with regard to backports, it seems like that would only be needed if the internals of the containerd log package changed (and that would likely be a v2), so I'd punt on that unless we need to.
And we'll likely want to backport whatever we do to address your FIXMEs in that eventuality, anyway.
|
Yes, I don't think backporting these changes is urgent. But wanted to have it here (before the 1.7 update), to keep the option open for the 23.0 and 24.0 branches if those are used for LTS versions. (It also wouldn't be too complicated to reconstruct these changes for those branches of course) |
- A picture of a cute animal (not mandatory but encouraged)