Skip to content

[DNM] ci: test buildkit features compat#45160

Closed
crazy-max wants to merge 2 commits intomoby:masterfrom
crazy-max:test_bk_features_compat
Closed

[DNM] ci: test buildkit features compat#45160
crazy-max wants to merge 2 commits intomoby:masterfrom
crazy-max:test_bk_features_compat

Conversation

@crazy-max
Copy link
Copy Markdown
Member

follow-up moby/buildkit#3713 (comment)

disable azblob and s3 cache backend tests

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 9635627)
@crazy-max crazy-max marked this pull request as draft March 14, 2023 15:24
@crazy-max crazy-max force-pushed the test_bk_features_compat branch 3 times, most recently from 6115268 to bfb2c88 Compare March 14, 2023 18:05
disable azblob and s3 cache backend tests

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the test_bk_features_compat branch from bfb2c88 to dff80ca Compare March 14, 2023 20:34
@thaJeztah
Copy link
Copy Markdown
Member

I think we had to test this one in combination with #45153

@crazy-max
Copy link
Copy Markdown
Member Author

@thaJeztah This PR was just to test for the s3 case: moby/buildkit#3713 (comment) but I can open another one with #45153

@thaJeztah
Copy link
Copy Markdown
Member

@crazy-max yeah, so on that PR we saw a failure, so I thought (assumed) we wanted to test the new changes in BuildKit to work with that PR (to exclude the things that need to be excluded with the new env-vars)?

Looks like this PR is green, so I guess we can re-use this PR to include the other PR to test if it also works with those changes.

@thaJeztah
Copy link
Copy Markdown
Member

🤦 OH! I see you already opened another PR; #45165 ?

@crazy-max
Copy link
Copy Markdown
Member Author

🤦 OH! I see you already opened another PR; #45165 ?

Yes that's the one for merge diff, and looks good: https://github.com/moby/moby/actions/runs/4425205314

@neersighted
Copy link
Copy Markdown
Member

It looks like we can close this as #44908 was merged?

@crazy-max crazy-max closed this Mar 16, 2023
@crazy-max crazy-max deleted the test_bk_features_compat branch March 16, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants