builder-next: disable mergeop and diffop#45153
Conversation
06d372e to
dde90a4
Compare
tonistiigi
left a comment
There was a problem hiding this comment.
Unless there is some time pressure with this, I'd make a different patch for master.
Merge/diff should be enabled when containerd is enabled. The ugly regexp can be avoided with some buildkit refactoring.
|
The change is targeted to the graphdrivers as it's in |
|
Looks like Ci is failing on master (perhaps differences between v0.10 and v0.11 of BuildKit and/or other changes) |
Will be sorted with moby/buildkit#3711 hopefully. Will look like this in the workflow: -
name: Test
run: |
./hack/test ${{ matrix.typ }}
env:
CONTEXT: "."
TEST_DOCKERD: "1"
TEST_DOCKERD_BINARY: "./build/moby/dockerd"
TESTPKGS: "./${{ matrix.pkg }}"
TESTFLAGS: "-v --parallel=1 --timeout=30m --run=//worker=dockerd$"
BUILDKIT_TEST_FEATURE_MERGEDIFF: "0"
working-directory: buildkit |
Yeah, that's a new test that didn't exist in v0.11. |
|
@neersighted looks like this one can be updated with changes from #45165 to help with CI (to skip tests) |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com>
dde90a4 to
b7b04d3
Compare
Co-authored-by: CrazyMax <crazy-max@users.noreply.github.com> Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com>
b7b04d3 to
f5050d4
Compare
Temporarily disable Merge/Diff until there is a proper solution to #45111. Dockerfiles will detect the missing capability for
COPY --linkand fall back to the behavior in 20.10.