integration: enforce features compat through env vars#3711
Merged
crazy-max merged 3 commits intomoby:masterfrom Mar 14, 2023
Merged
integration: enforce features compat through env vars#3711crazy-max merged 3 commits intomoby:masterfrom
crazy-max merged 3 commits intomoby:masterfrom
Conversation
fb2e9c9 to
f725f3f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
f725f3f to
fd7081c
Compare
ff9b137 to
94d8883
Compare
thaJeztah
reviewed
Mar 13, 2023
thaJeztah
reviewed
Mar 13, 2023
tonistiigi
reviewed
Mar 13, 2023
tonistiigi
reviewed
Mar 13, 2023
tonistiigi
reviewed
Mar 13, 2023
94d8883 to
710aa17
Compare
tonistiigi
reviewed
Mar 13, 2023
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
710aa17 to
5102c5a
Compare
tonistiigi
approved these changes
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up moby/moby#44079 (comment)
Adds ability to enforce features compatibility check through env vars in integration tests.
For example to disable
integration.FeatureCacheExportandintegration.FeatureCacheImportfeature you can setBUILDKIT_TEST_DISABLE_FEATURES=cache_export,cache_import. SetBUILDKIT_TEST_ENABLE_FEATURES=cache_export,cache_importto enable.Also adds extra features compat for specific cache backends and mergediff.