Skip to content

replace pkg/fileutils Matching funcs with github.com/moby/patternmatcher#44226

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:migrate_filematcher
Sep 30, 2022
Merged

replace pkg/fileutils Matching funcs with github.com/moby/patternmatcher#44226
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:migrate_filematcher

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Sep 30, 2022 •
edited
Loading

@thaJeztah thaJeztah mentioned this pull request Sep 30, 2022
Merged
@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 30, 2022

@tonistiigi @aaronlehmann @cpuguy83 PTAL (I haven't tagged a release yet, but can do if we're all happy with the current state)

@thaJeztah thaJeztah added this to the v-next milestone Sep 30, 2022
cpuguy83
cpuguy83 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is hard, but LGTM

I feel like someone must be watching me because I just had to import buildkit to test some things out and ran into the go.mod replacement for docker/docker.

@thaJeztah thaJeztah mentioned this pull request Sep 30, 2022
Closed
@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 30, 2022

Yes, it was a pretty hairy one, and this one kept dropping off my list, thought I'd spend a bit of time to finally have it done.

Also not super happy with the name, but couldn't come up with a better one 😂 (and didn't want to waste time bike-shedding)

@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 30, 2022

This needs a rebase now; as #44221 was merged, but I'll wait for CI to be happy here (and in tonistiigi/fsutil#136, then tag a v0.5.0 (there's some functions marked "deprecated", and maybe we want to / can remove those before v1.0.0), then update my PRs

@thaJeztah
replace pkg/fileutils Matching funcs with github.com/moby/patternmatcher
3c69b9f 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 30, 2022

Tagged it as v0.5.0 and rebase; should be all good now 👍

@thaJeztah thaJeztah mentioned this pull request Sep 30, 2022
Merged
@thaJeztah thaJeztah mentioned this pull request Sep 30, 2022
Merged
@thaJeztah thaJeztah merged commit f8c7eb2 into moby:master Sep 30, 2022
@thaJeztah thaJeztah deleted the migrate_filematcher branch September 30, 2022 22:32
@thaJeztah thaJeztah mentioned this pull request Oct 6, 2022
Merged
@thaJeztah thaJeztah mentioned this pull request Nov 14, 2022
Closed
@thaJeztah thaJeztah mentioned this pull request Jan 30, 2023
Merged
@thaJeztah thaJeztah mentioned this pull request Apr 3, 2023
Merged
@mye956 mye956 mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@tonistiigi tonistiigi Awaiting requested review from tonistiigi tonistiigi is a code owner

+1 more reviewer

@aaronlehmann aaronlehmann aaronlehmann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/refactor PR's that refactor, or clean-up code process/cherry-picked status/4-merge

Projects

None yet

Milestone

24.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @cpuguy83 @AkihiroSuda @aaronlehmann