Skip to content

pkg/fileutils: split filematcher to separate files#42491

Closed
thaJeztah wants to merge 2 commits intomoby:masterfrom
thaJeztah:split_fileutils
Closed

pkg/fileutils: split filematcher to separate files#42491
thaJeztah wants to merge 2 commits intomoby:masterfrom
thaJeztah:split_fileutils

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jun 9, 2021

This is an intermediate state for this package; planning to move this to github.com/tonistiigi/fsutil (or a separate repository). Splitting it here before moving makes the transition easier.

Aliases were added for backward compatibility, but uses of this code inside our codebase wasn't changed (yet) to prevent codechurn (once the move of this code to the tonistiigi/fsutil repository is completed).

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Jun 9, 2021
@@ -0,0 +1,230 @@
package filematch

This comment was marked as outdated.

@thaJeztah

This comment was marked as outdated.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah marked this pull request as ready for review March 18, 2022 16:44
@thaJeztah thaJeztah requested a review from tonistiigi as a code owner March 18, 2022 16:44
@thaJeztah thaJeztah marked this pull request as draft March 18, 2022 17:03
@thaJeztah thaJeztah changed the title pkg/fileutils: split filematcher to separate package pkg/fileutils: split filematcher to separate files Mar 18, 2022
@thaJeztah thaJeztah marked this pull request as ready for review March 18, 2022 17:07
@thaJeztah
Copy link
Copy Markdown
Member Author

superseded by #44226

@thaJeztah thaJeztah closed this Nov 14, 2022
@thaJeztah thaJeztah deleted the split_fileutils branch November 14, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant