containerd integration: compute virtualsize#43815
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Jul 18, 2022
Merged
Conversation
AkihiroSuda
reviewed
Jul 16, 2022
daemon/containerd/service.go
Outdated
| } | ||
|
|
||
| var ret []*types.ImageSummary | ||
| snapshotter := cs.client.SnapshotService(containerd.DefaultSnapshotter) |
Member
There was a problem hiding this comment.
DefaultSnapshotter
Will this be configurable in a follow-up PR?
LGTM then
Member
Author
There was a problem hiding this comment.
Yes, we should make this configurable; looks like https://github.com/rumpl/moby is currently only using the default (but that's hard-coded in containerd to overlayfs for Linux), and we should make that configurable, similar to the existing graph drivers (and have feature detection, likely, if we also want automatic selection)
./cc @rumpl
Member
There was a problem hiding this comment.
Indeed we haven't yet added this but we definitely need it, there are some docker commands that will need to have a --snapshotter flag.
a3f9316 to
a38eed2
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
a38eed2 to
a46ce37
Compare
Member
Author
|
Interesting failure (should not be related?); Details |
thaJeztah
commented
Jul 18, 2022
| return virtualSize, err | ||
| } | ||
| for _, chainID := range identity.ChainIDs(diffIDs) { | ||
| usage, err := snapshotter.Usage(ctx, chainID.String()) |
Member
Author
There was a problem hiding this comment.
FWIW; some optimisations coming when upstreaming rumpl#17 - let me have a look if I can include that one in this PR
Member
Author
There was a problem hiding this comment.
Actually, that makes things a bit more complicated; let me keep it separate for now
corhere
approved these changes
Jul 18, 2022
crazy-max
pushed a commit
to crazy-max/moby
that referenced
this pull request
Sep 29, 2022
containerd integration: compute virtualsize Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstreaming more commits from https://github.com/rumpl/moby
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)