Fix HNS policylist error "network not found" during network removal#43502
Fix HNS policylist error "network not found" during network removal#43502thaJeztah merged 3 commits intomoby:masterfrom
Conversation
Signed-off-by: Trapier Marshall <tmarshall@mirantis.com>
Removal of PolicyLists from Windows VFP must be performed prior to removing the HNS network. Otherwise PolicyList removal fails with HNS error "network not found". Signed-off-by: Trapier Marshall <tmarshall@mirantis.com>
Make the call to cleanupServiceBindings during network deletion conditional on Windows (where it is required), thereby providing a performance improvement to network cleanup on Linux. Signed-off-by: Trapier Marshall <tmarshall@mirantis.com>
tianon
left a comment
There was a problem hiding this comment.
Seems OK to me, but we probably need an answer to moby/libnetwork#2620 (comment) one way or another.
|
Assuming that commit messages are correct where that line was added moby/libnetwork@b6b8023 and here then that condition just works as performance improvement for Linux. |
Thanks; yes don't think that is a blocker for this PR; perhaps we should create a tracking issue to look into cleaning it up a bit. It's a bit confusing (and not a huge fan of) "wishy-washy" "here we call it", and "here we don't". If the code is not needed on Linux, the function itself should ideally take care of that, or we should differentiate some code further to be platform specific. Anyway; not a blocker (and not your fault 😅) |
Fixes #41354 (moby/libnetwork#2620 (comment))
- What I did
Copied commits from moby/libnetwork#2620 as this looks to be missing from here but exists on Mirantis Container Engine (Mirantis/libnetwork#4) afaiu.
- How I did it
git cherry-pick ...
- How to verify it
Hopefully passes CI.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)