[20.10] Fix HNS policylist error "network not found" during network removal#4
Merged
ameyag merged 3 commits intoMirantis:custom_bump_20.10from May 6, 2021
Merged
Conversation
added 3 commits
May 6, 2021 12:39
Signed-off-by: Trapier Marshall <tmarshall@mirantis.com> (cherry picked from commit a9c349a60633d5612fc0b4d6c4c3a65da9b91933) Signed-off-by: Ameya Gawde <agawde@mirantis.com>
Removal of PolicyLists from Windows VFP must be performed prior to removing the HNS network. Otherwise PolicyList removal fails with HNS error "network not found". Signed-off-by: Trapier Marshall <tmarshall@mirantis.com> (cherry picked from commit 6f36306d8b17ee7e960cf42eed499b768ef3d9a9) Signed-off-by: Ameya Gawde <agawde@mirantis.com>
Make the call to cleanupServiceBindings during network deletion conditional on Windows (where it is required), thereby providing a performance improvement to network cleanup on Linux. Signed-off-by: Trapier Marshall <tmarshall@mirantis.com> (cherry picked from commit 047ac186dac9785e1dacb9ac96897a9dda5c4c09) Signed-off-by: Ameya Gawde <agawde@mirantis.com>
ry4nz
approved these changes
May 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍒 : moby/libnetwork#2620