api: add missing docs for KernelMemoryTCP, and fix error message#43277
Merged
thaJeztah merged 3 commits intomoby:masterfrom Mar 3, 2022
Merged
api: add missing docs for KernelMemoryTCP, and fix error message#43277thaJeztah merged 3 commits intomoby:masterfrom
thaJeztah merged 3 commits intomoby:masterfrom
Conversation
While this feature is deprecated / unsupported on cgroups v2, it's part of the API, so let's at least document it. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
tianon
reviewed
Feb 26, 2022
| } | ||
| if resources.KernelMemory > 0 && resources.KernelMemory < linuxMinMemory { | ||
| return warnings, fmt.Errorf("Minimum kernel memory limit allowed is 4MB") | ||
| return warnings, fmt.Errorf("Minimum kernel memory limit allowed is 6MB") |
Member
Author
There was a problem hiding this comment.
hehe, yes, that's where these commits came from, but thought to move them out of that PR, as they already apply to the current API (and perhaps making the other PR slightly easier / smaller to review)
Member
Author
|
I'm gonna take a plunge here; this PR should be safe, and (mostly) for docs, so let's get this in |
Member
Author
|
oh, actually; no LGTM yet 🙈 ... this LGTY, @tianon, or do you want to change the error to use a |
tianon
approved these changes
Mar 3, 2022
Member
tianon
left a comment
There was a problem hiding this comment.
Sorry, yep, sounds good to me!
Member
Author
|
Thx! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken from #43214