Remove the deprecated '--kernel-memory' option on API v1.42 and up by thaJeztah · Pull Request #43214 · moby/moby

thaJeztah · 2022-02-07T17:31:00Z

Carry of Remove the deprecated '--kernel-memory' option #42854

Add missing KernelMemoryTCP to docs (for /info endpoint)

Update handling of deprecated kernel (tcp) memory options

Omit KernelMemory and KernelMemoryTCP fields in /info response if they're
not supported, or when using API v1.42 or up.
Re-enable detection of KernelMemory (as it's still needed for older API versions)
Remove warning about kernel memory TCP in daemon logs (a warning is still returned
by the /info endpoint, but we can consider removing that).
Prevent incorrect "Minimum kernel memory limit allowed" error if the value was
reset because it's not supported by the host.

api/types: fix KernelMemory deprecation comment, and omitempty

Ignore the kernel memory option if set in HostConfig on container create.
We keep the option in the API ( for the containers/create and /info endpoints) until the next API version release but ignore any value it is set to.

root@80b7d3e03521:~# curl --unix-socket /var/run/docker.sock -H "Content-Type: application/json" -d '{"Image": "alpine", "Cmd": ["echo", "hello world"], "HostConfig": {"KernelMemory": 299900}}' -X POST http://localhost/v1.41/containers/create
{"Id":"4d8537d9cee548938492d489b7d8394b46ae75992d89875fbf2b33971762a552","Warnings":["Specifying a kernel memory limit is not supported anymore."]}

root@80b7d3e03521:~# docker inspect 4d8537d9cee5
[
    {
        "Id": "4d8537d9cee548938492d489b7d8394b46ae75992d89875fbf2b33971762a552",
....
            "KernelMemory": 0,
            "KernelMemoryTCP": 0,
            "MemoryReservation": 0,
....

root@80b7d3e03521:~# curl -s --unix-socket /var/run/docker.sock http://localhost/info | jq .| grep KernelMemory
  "KernelMemoryTCP": false,

daemon/daemon_unix.go

thaJeztah · 2022-02-18T00:50:24Z

@AkihiroSuda ptal

thaJeztah · 2022-02-22T09:30:57Z

Extracted the first 3 commits to #43277

thaJeztah · 2022-03-03T20:34:00Z

Hmm. failure on Microsoft's registry 😅 ;

INFO: Pulling mcr.microsoft.com/windows/servercore:ltsc2022 from docker hub into daemon under test. This may take some time...
[2022-03-03T18:52:32.643Z] powershell.exe : Error response from daemon: Get "https://mcr.microsoft.com/v2/windows/servercore/manifests/sha256:720729320e08bdf14b6bc16444be6a3b74a457bd0584fee5124e6073e9f8f1cf: dial tcp 
[2022-03-03T18:52:32.643Z] 131.253.33.219:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host

rumpl · 2022-03-16T14:05:58Z

docs/api/version-history.md

  invalid `condition` is provided (on API 1.30 and up).
+* Removed the `KernelMemory` field from the `POST /containers/create` and
+  `POST /containers/{id}/update` endpoints, any value it is set to will be ignored
+  on API version `v1.41` and up. Older API versions still accept this field, but


Shouldn't this be v1.42 and up?

Ah, dang! Yes, let me fix that

fixed 👍 PTAL

- remove KernelMemory option from `v1.42` api docs - remove KernelMemory warning on `/info` - update changes for `v1.42` - remove `KernelMemory` field from endpoints docs Signed-off-by: aiordache <anca.iordache@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

- Omit `KernelMemory` and `KernelMemoryTCP` fields in `/info` response if they're not supported, or when using API v1.42 or up. - Re-enable detection of `KernelMemory` (as it's still needed for older API versions) - Remove warning about kernel memory TCP in daemon logs (a warning is still returned by the `/info` endpoint, but we can consider removing that). - Prevent incorrect "Minimum kernel memory limit allowed" error if the value was reset because it's not supported by the host. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

This fixes the "deprecated" comment to have the correct format to be picked up by editors, and adds `omitempty` labels for KernelMemory and KernelMemoryTCP. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

rumpl

LGTM

AkihiroSuda · 2022-03-17T10:33:48Z

LGTM, but maybe we should print some warning when --kernel-memory was specified?

thaJeztah · 2022-03-17T10:48:59Z

but maybe we should print some warning when --kernel-memory was specified?

Perhaps we could do something yes; need to think a bit what logic to use for that warning;

--kernel-memory will be deprecated/hidden on the CLI (based on the API version used), so we'll likely print a warning on that side
if an older API version is used, but a value is set, we could indeed print a warning that the runtime may ignore the option

For the second case, we could propagate the Warnings in the container create response

Are you OK with me doing that in a follow-up?

AkihiroSuda · 2022-03-17T10:55:17Z

Are you OK with me doing that in a follow-up?

Yes 👍

thaJeztah added area/api API impact/api impact/changelog impact/deprecation labels Feb 7, 2022

tianon approved these changes Feb 8, 2022

View reviewed changes

daemon/daemon_unix.go Outdated Show resolved Hide resolved

thaJeztah added the status/2-code-review label Feb 14, 2022

thaJeztah added this to the 21.xx milestone Feb 14, 2022

This comment was marked as spam.

Sign in to view

inosgun approved these changes Feb 19, 2022

View reviewed changes

thaJeztah mentioned this pull request Feb 22, 2022

api: add missing docs for KernelMemoryTCP, and fix error message #43277

Merged

thaJeztah force-pushed the carry_42854_rm_options branch from 0ad089a to 3322447 Compare March 3, 2022 18:35

rumpl reviewed Mar 16, 2022

View reviewed changes

aiordache and others added 3 commits March 17, 2022 09:55

api/types: fix KernelMemory deprecation comment, and omitempty

427b0cd

This fixes the "deprecated" comment to have the correct format to be picked up by editors, and adds `omitempty` labels for KernelMemory and KernelMemoryTCP. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah force-pushed the carry_42854_rm_options branch from 3322447 to 427b0cd Compare March 17, 2022 08:56

rumpl approved these changes Mar 17, 2022

View reviewed changes

AkihiroSuda approved these changes Mar 17, 2022

View reviewed changes

AkihiroSuda merged commit 0798f5f into moby:master Mar 17, 2022

thaJeztah mentioned this pull request Mar 17, 2022

Remove the deprecated '--kernel-memory' option #42854

Closed

thaJeztah deleted the carry_42854_rm_options branch March 17, 2022 12:33

thaJeztah mentioned this pull request Apr 9, 2022

update status of deprecated features for 22.04 (docs, and some code) docker/cli#3542

Merged

thaJeztah mentioned this pull request Sep 13, 2022

client: ignore kernel-memory on API >= 1.42 #44138

Merged

thaJeztah mentioned this pull request Sep 21, 2022

[22.06 backport] client: ignore kernel-memory on API >= 1.42 #44164

Merged

thaJeztah mentioned this pull request Sep 16, 2025

Remove support for deprecated kernel memory limit #50989

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the deprecated '--kernel-memory' option on API v1.42 and up#43214

Remove the deprecated '--kernel-memory' option on API v1.42 and up#43214
AkihiroSuda merged 3 commits intomoby:masterfrom
thaJeztah:carry_42854_rm_options

thaJeztah commented Feb 7, 2022

Uh oh!

Uh oh!

thaJeztah commented Feb 18, 2022

Uh oh!

This comment was marked as spam.

thaJeztah commented Feb 22, 2022

Uh oh!

thaJeztah commented Mar 3, 2022 •

edited

Loading

Uh oh!

rumpl Mar 16, 2022

Uh oh!

thaJeztah Mar 17, 2022

Uh oh!

thaJeztah Mar 17, 2022

Uh oh!

rumpl left a comment

Uh oh!

AkihiroSuda commented Mar 17, 2022

Uh oh!

thaJeztah commented Mar 17, 2022

Uh oh!

AkihiroSuda commented Mar 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

thaJeztah commented Feb 7, 2022

Uh oh!

Uh oh!

thaJeztah commented Feb 18, 2022

Uh oh!

This comment was marked as spam.

thaJeztah commented Feb 22, 2022

Uh oh!

thaJeztah commented Mar 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rumpl Mar 16, 2022

Choose a reason for hiding this comment

Uh oh!

thaJeztah Mar 17, 2022

Choose a reason for hiding this comment

Uh oh!

thaJeztah Mar 17, 2022

Choose a reason for hiding this comment

Uh oh!

rumpl left a comment

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda commented Mar 17, 2022

Uh oh!

thaJeztah commented Mar 17, 2022

Uh oh!

AkihiroSuda commented Mar 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

thaJeztah commented Mar 3, 2022 •

edited

Loading