Skip to content

Deprecate BuilderSize in API versions >= 1.42#42608

Merged
thaJeztah merged 1 commit intomoby:masterfrom
rvolosatovs:fix_builder_size
Jul 12, 2021
Merged

Deprecate BuilderSize in API versions >= 1.42#42608
thaJeztah merged 1 commit intomoby:masterfrom
rvolosatovs:fix_builder_size

Conversation

@rvolosatovs
Copy link

@rvolosatovs rvolosatovs commented Jul 8, 2021

Refs #42605 (comment)

- What I did
Ensure BuilderSize is not set for API versions >= 1.42

- How I did it

  • Add a version check in the router
  • Add omitempty JSON tag
  • Document in version history doc

- How to verify it

curl -s --unix-socket /var/run/docker.sock http://localhost/system/df | jq

Should not show BuilderSize field

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 21.xx milestone Jul 8, 2021
thaJeztah
thaJeztah approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonistiigi PTAL

@thaJeztah thaJeztah requested a review from tonistiigi July 8, 2021 11:55
tonistiigi
tonistiigi reviewed Jul 9, 2021
View reviewed changes
docs/api/version-history.md Outdated
Copy link
Member

@tonistiigi tonistiigi Jul 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Use field BuildCache instead to track storage used by the builder component."

@thaJeztah
API: deprecate BuilderSize in API versions >= 1.42
31348af 
Co-authored-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Roman Volosatovs <roman.volosatovs@docker.com>
@rvolosatovs rvolosatovs requested a review from tonistiigi July 12, 2021 08:05
thaJeztah
thaJeztah approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

@thaJeztah
Copy link
Member

thaJeztah commented Jul 12, 2021

Failure on RS5 is unrelated (tracked in #42484)

=== RUN   TestNetworkDBCRUDMediumCluster
    networkdb_test.go:439: Network existence verification failed
    networkdb_test.go:439: Network existence verification failed
2021/07/12 08:28:50 Closing DB instances...
time="2021-07-12T08:28:50Z" level=error msg="node: 4dd9d108bf92 is unknown to memberlist"
time="2021-07-12T08:28:51Z" level=error msg="node: 84aa11ae046e is unknown to memberlist"
time="2021-07-12T08:28:52Z" level=error msg="node: 7b39e4147b5e is unknown to memberlist"
--- FAIL: TestNetworkDBCRUDMediumCluster (12.66s)

@thaJeztah thaJeztah merged commit bf78e25 into moby:master Jul 12, 2021
@rvolosatovs rvolosatovs deleted the fix_builder_size branch July 12, 2021 18:04
mfeit-internet2 pushed a commit to mfeit-internet2/moby that referenced this pull request Jul 13, 2021
@thaJeztah
Merge pull request moby#42608 from rvolosatovs/fix_builder_size
0fc3d90 
Deprecate `BuilderSize` in API versions >= 1.42
Signed-off-by: Mark Feit <mfeit@internet2.edu>
@thaJeztah thaJeztah mentioned this pull request Oct 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

area/api API impact/api impact/changelog impact/deprecation kind/experimental status/2-code-review

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@rvolosatovs @thaJeztah @tonistiigi