Skip to content

Remove LCOW (step 4): remove layerstore indexing by OS (used for LCOW)#42511

Merged
justincormack merged 1 commit intomoby:masterfrom
thaJeztah:remove_lcow_step4
Jun 11, 2021
Merged

Remove LCOW (step 4): remove layerstore indexing by OS (used for LCOW)#42511
justincormack merged 1 commit intomoby:masterfrom
thaJeztah:remove_lcow_step4

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jun 10, 2021

splitting off from #42170

@thaJeztah
remove layerstore indexing by OS (used for LCOW)
dc7cbb9 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added status/2-code-review kind/experimental area/lcow Issues and PR's related to the experimental LCOW feature labels Jun 10, 2021
@thaJeztah thaJeztah requested a review from tonistiigi June 10, 2021 19:08
@thaJeztah thaJeztah added this to the 21.xx milestone Jun 10, 2021
@thaJeztah
Copy link
Member Author

thaJeztah commented Jun 10, 2021

Found another flaky test

=== RUN   TestRequestReleaseAddressDuplicate
--- FAIL: TestRequestReleaseAddressDuplicate (0.01s)
    allocator_test.go:1533: IP 198.168.1.97/23 was previously allocated

@justincormack justincormack merged commit 1ba54a5 into moby:master Jun 11, 2021
@thaJeztah thaJeztah deleted the remove_lcow_step4 branch June 11, 2021 17:46
@thaJeztah thaJeztah mentioned this pull request Jul 9, 2021
Closed
@thaJeztah
Copy link
Member Author

thaJeztah commented Jul 9, 2021

Opened #42612 for the flaky test

@thaJeztah thaJeztah mentioned this pull request Jul 29, 2021
Merged
rumpl added a commit to rumpl/moby that referenced this pull request Mar 24, 2022
@rumpl
Remove comment that is no longer relevant
c2f1377 
The moby#42511 PR remved layer store indexing by OS but this comment was left behind

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl added a commit to rumpl/moby that referenced this pull request Mar 24, 2022
@rumpl
Remove comment that is no longer relevant
7b277f6 
The moby#42511 PR removed layer store indexing by OS but this comment was left behind

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
@rumpl rumpl mentioned this pull request Mar 24, 2022
Merged
@thaJeztah thaJeztah mentioned this pull request Jul 12, 2023
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@tonistiigi tonistiigi Awaiting requested review from tonistiigi

+1 more reviewer

@justincormack justincormack justincormack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/lcow Issues and PR's related to the experimental LCOW feature impact/deprecation kind/experimental status/2-code-review

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @justincormack @AkihiroSuda