Skip to content

Bump Golang 1.13.11#40977

Merged
cpuguy83 merged 1 commit intomoby:masterfrom
thaJeztah:bump_golang_1.13.11
May 19, 2020
Merged

Bump Golang 1.13.11#40977
cpuguy83 merged 1 commit intomoby:masterfrom
thaJeztah:bump_golang_1.13.11

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented May 16, 2020

full diff: golang/go@go1.13.10...go1.13.11

go1.13.11 (released 2020/05/14) includes fixes to the compiler. See the Go 1.13.11
milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.13.11+label%3ACherryPickApproved

@thaJeztah thaJeztah added this to the 20.03.0 milestone May 16, 2020
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 16, 2020

Golang update looks to be fixing issues on s390x

@thaJeztah thaJeztah mentioned this pull request May 16, 2020
Merged
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 16, 2020

Wait; why are all builds failing?


[2020-05-16T13:13:07.334Z] #43 [gotestsum 1/1] RUN --mount=type=cache,target=/root/.cache/go-build     ...
[2020-05-16T13:13:07.334Z] #43 107.2 + cd /tmp/tmp.AtFYNgLZrz/src/gotest.tools/gotestsum
[2020-05-16T13:13:07.334Z] #43 107.2 + git checkout -q v0.3.5
[2020-05-16T13:13:07.334Z] #43 107.3 + go build -buildmode=pie -o /build/gotestsum gotest.tools/gotestsum
[2020-05-16T13:13:07.334Z] #43 108.0 handler.go:8:2: cannot find package "github.com/sirupsen/logrus" in any of:
[2020-05-16T13:13:07.334Z] #43 108.0 	/usr/local/go/src/github.com/sirupsen/logrus (from $GOROOT)
[2020-05-16T13:13:07.334Z] #43 108.0 	/tmp/tmp.AtFYNgLZrz/src/github.com/sirupsen/logrus (from $GOPATH)
[2020-05-16T13:13:07.334Z] #43 ERROR: executor failed running [/bin/sh -c PREFIX=/build /tmp/install/install.sh gotestsum]: runc did not terminate sucessfully



[2020-05-16T13:13:02.644Z] #39 [criu 2/2] RUN mkdir -p /usr/src/criu     && curl -sSL https://github.co...
[2020-05-16T13:13:02.644Z] #39 3.600 Note: Building without setproctitle() and strlcpy() support.
[2020-05-16T13:13:02.644Z] #39 3.600       To enable these features, please install libbsd-devel (RPM) / libbsd-dev (DEB).
[2020-05-16T13:13:02.644Z] #39 3.624 Note: Building without GnuTLS support
[2020-05-16T13:13:04.546Z] #39 5.382 fatal: not a git repository (or any of the parent directories): .git
[2020-05-16T13:13:04.546Z] #39 5.477   GEN      .gitid
[2020-05-16T13:13:04.546Z] #39 ...
[2020-05-16T13:13:04.546Z]

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 16, 2020

Kicked CI to see if it was a temporary issue with GitHub

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 16, 2020

Nope; looks like an actual regression?

Wondering if it's an issue in the image, or golang

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 16, 2020

So... I just saw gotestyourself/gotestsum#110

Is go modules somehow looking for the go modules from "master" instead of the version we checked out???

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 16, 2020

OK, so this fails on Go 1.13.10 as well.

What happens is;

First, we go get the package;

GO111MODULE=off go get -d gotest.tools/gotestsum

Which gets the latest version from master, and fetches the dependencies used on master

Then we checkout the v0.3.5 version, and run go build

that fails, because master no longer depends on logrus (so the initial go get didn't fetch it), and v0.3.5 does

@thaJeztah thaJeztah mentioned this pull request May 16, 2020
Merged
@thaJeztah thaJeztah force-pushed the bump_golang_1.13.11 branch from 00d09f7 to 122ead6 Compare May 16, 2020 16:44
@thaJeztah thaJeztah requested a review from tianon as a code owner May 16, 2020 16:44
@thaJeztah thaJeztah marked this pull request as draft May 16, 2020 16:44
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 16, 2020

moved to draft, waiting for #40979 to be merged

@thaJeztah thaJeztah force-pushed the bump_golang_1.13.11 branch 2 times, most recently from e36d7f4 to 993a175 Compare May 16, 2020 17:00
@thaJeztah
Bump Golang 1.13.11
90758fb 
full diff: golang/go@go1.13.10...go1.13.11

go1.13.11 (released 2020/05/14) includes fixes to the compiler. See the Go 1.13.11
milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.13.11+label%3ACherryPickApproved

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the bump_golang_1.13.11 branch from 993a175 to 90758fb Compare May 17, 2020 20:57
@thaJeztah thaJeztah marked this pull request as ready for review May 17, 2020 20:57
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 18, 2020

Looks like ppc64le images are missing; build status: https://doi-janky.infosiftr.net/job/multiarch/job/ppc64le/job/golang/. Some previous builds failed because the node was out of disk space; perhaps that's the problem?

E: Failed to fetch http://deb.debian.org/debian/dists/buster/main/binary-ppc64el/Packages  Error writing to output file - write (28: No space left on device) [IP: 172.17.0.2 80]
E: Some index files failed to download. They have been ignored, or old ones used instead.

/cc @tianon ^^

@tianon
Copy link
Copy Markdown
Member

tianon commented May 19, 2020

Yeah sorry, the server filled up thanks to several base updates in a row and then took a long time to churn through the queue; it should be fixed/finished now!

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 19, 2020

No worries! I don't think there was an urgency in this specific update of Go.

Kicking jenkins to see if it goes green; thanks!

cpuguy83
cpuguy83 approved these changes May 19, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 6a2e1ac into moby:master May 19, 2020
@thaJeztah thaJeztah deleted the bump_golang_1.13.11 branch May 19, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@tianon tianon Awaiting requested review from tianon

Assignees

No one assigned

Labels

process/cherry-picked status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @tianon @cpuguy83 @AkihiroSuda