Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.13.10
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.13.11
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Apr 28, 2020

  1. [release-branch.go1.13] cmd/compile: fix deallocation of live value c…

    …opies in regalloc
    
    When deallocating the input register to a phi so that the phi
    itself could be allocated to that register the code was also
    deallocating all copies of that phi input value. Those copies
    of the value could still be live and if they were the register
    allocator could reuse them incorrectly to hold speculative
    copies of other phi inputs. This causes strange bugs.
    
    No test because this is a very obscure scenario that is hard
    to replicate but CL 228060 adds an assertion to the compiler
    that does trigger when running the std tests on linux/s390x
    without this CL applied. Hopefully that assertion will prevent
    future regressions.
    
    Fixes #38442.
    
    Change-Id: Id975dadedd731c7bb21933b9ea6b17daaa5c9e1d
    Reviewed-on: https://go-review.googlesource.com/c/go/+/228061
    Run-TryBot: Michael Munday <mike.munday@ibm.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Keith Randall <khr@golang.org>
    (cherry picked from commit 382fe3e)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/230358
    mundaym authored and andybons committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    6b974e2 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. [release-branch.go1.13] go1.13.11

    Change-Id: I6fb5fbb3caf64e7d33412be4893edf8564e3a4de
    Reviewed-on: https://go-review.googlesource.com/c/go/+/234001
    Run-TryBot: Andrew Bonventre <andybons@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    andybons committed May 14, 2020
    Configuration menu
    Copy the full SHA
    237b606 View commit details
    Browse the repository at this point in the history
Loading