Skip to content

Revert "Jenkinsfile: temporarily pin windows image to 10.0.17763.973"#40512

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:revert_jenkinsfile_pin_older_windows
Feb 26, 2020
Merged

Revert "Jenkinsfile: temporarily pin windows image to 10.0.17763.973"#40512
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:revert_jenkinsfile_pin_older_windows

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Feb 13, 2020

This reverts commit fa24179 #40506

@thaJeztah
Revert "Jenkinsfile: temporarily pin windows image to 10.0.17763.973"
8a52139 
This reverts commit fa24179.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this pull request Feb 13, 2020
Merged
@StefanScherer
Copy link
Copy Markdown
Contributor

StefanScherer commented Feb 13, 2020 •
edited
Loading

Hm, building the Windows container image now works, but the build fails later on. 🤔

[2020-02-13T10:58:07.818Z] Step 10/10 : COPY . .
[2020-02-13T10:58:28.825Z]  ---> 2d473e87ab9c
[2020-02-13T10:58:28.825Z] Successfully built 2d473e87ab9c
[2020-02-13T10:58:28.825Z] Successfully tagged docker:latest
[2020-02-13T10:58:28.825Z] INFO: Image build ended at 02/13/2020 10:58:28. Duration:00:03:40.3168087
[2020-02-13T10:58:28.825Z] 
[2020-02-13T10:58:28.825Z] 
[2020-02-13T10:58:28.825Z] INFO: Building the test binaries at 02/13/2020 10:58:28...
[2020-02-13T10:58:32.593Z] INFO: make.ps1 starting at 02/13/2020 10:58:31
[2020-02-13T10:58:32.593Z] INFO: Git commit (8a52139a0f) assumed from DOCKER_GITCOMMIT environment variable
[2020-02-13T10:58:32.593Z] INFO: Invoking autogen...
[2020-02-13T10:58:33.548Z] 
[2020-02-13T10:58:33.548Z] ERROR: make.ps1 failed:
[2020-02-13T10:58:33.548Z] .go-autogen.ps1 failed with error Failed to compile event message resources
[2020-02-13T10:58:33.548Z] At C:\gopath\src\github.com\docker\docker\hack\make\.go-autogen.ps1:83 char:5
[2020-02-13T10:58:33.548Z] +     Throw ".go-autogen.ps1 failed with error $_"
[2020-02-13T10:58:33.548Z] +     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[2020-02-13T10:58:33.548Z] 
[2020-02-13T10:58:33.549Z] ___________      .__.__             .___
[2020-02-13T10:58:33.549Z] \_   _____/____  |__|  |   ____   __| _/
[2020-02-13T10:58:33.549Z]  |    __) \__  \ |  |  | _/ __ \ / __ | 
[2020-02-13T10:58:33.549Z]  |     \   / __ \|  |  |_\  ___// /_/ | 
[2020-02-13T10:58:33.549Z]  \___  /  (____  /__|____/\___  >____ | 
[2020-02-13T10:58:33.549Z]      \/        \/             \/     \/ 
[2020-02-13T10:58:33.549Z] 
[2020-02-13T10:58:33.549Z] INFO: make.ps1 ended at 02/13/2020 10:58:33
[2020-02-13T10:58:34.505Z] 
[2020-02-13T10:58:34.505Z] 
[2020-02-13T10:58:34.505Z] ERROR: Failed 'ERROR: Failed to build binary' at 02/13/2020 10:58:34
[2020-02-13T10:58:34.505Z] At D:\gopath\src\github.com\docker\docker\hack\ci\windows.ps1:516 char:13
[2020-02-13T10:58:34.505Z] +             Throw "ERROR: Failed to build binary"
[2020-02-13T10:58:34.505Z] +             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Just a flakeyness?

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Feb 13, 2020

Interesting, haven't seen that error before. Let me kick it again, to see if it was indeed just a flake

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Feb 13, 2020

Failing again with Failed to compile event message resources, so looks like it's an actual issue / regression in Windows 😞

@StefanScherer
Copy link
Copy Markdown
Contributor

StefanScherer commented Feb 13, 2020

Weird, do you encounter that problem in other PR's today?
I ask because the Azure agents are now updated to 10.0.17763.1039, but our temporary fix still uses the older 10.0.17763.973 base image.
If it also fails in other PR's using the older image I would rollback to the previous VM image.

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Feb 13, 2020

Good one; yes, looks like this PR also fails; #40510 https://ci-next.docker.com/public/blue/organizations/jenkins/moby/detail/PR-40510/3/pipeline

This was referenced Feb 13, 2020
Merged
Merged
@StefanScherer
Copy link
Copy Markdown
Contributor

StefanScherer commented Feb 13, 2020

Alright, I've rolled back to the previous VM images.

@thaJeztah thaJeztah changed the title Revert "Jenkinsfile: temporarily pin windows image to 10.0.17763.973" [HOLD] Revert "Jenkinsfile: temporarily pin windows image to 10.0.17763.973" Feb 13, 2020
@StefanScherer StefanScherer mentioned this pull request Feb 15, 2020
Merged
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Feb 21, 2020

Added "cherry-pick" label, because I'm backporting the temporary fix in #40551

@StefanScherer
Copy link
Copy Markdown
Contributor

StefanScherer commented Feb 26, 2020

@thaJeztah I've triggered another RS5 build, now with the latest VM image (10.0.17763.1039) again and it uses also the latest patched base image (10.0.17763.1040). This build is 💚 again.
So, it's time to remove the workaround.

@StefanScherer StefanScherer mentioned this pull request Feb 26, 2020
Merged
@thaJeztah thaJeztah changed the title [HOLD] Revert "Jenkinsfile: temporarily pin windows image to 10.0.17763.973" Revert "Jenkinsfile: temporarily pin windows image to 10.0.17763.973" Feb 26, 2020
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Feb 26, 2020

Thanks! I'll merge this one (ugh; forgot that updating a PR title triggers CI)

Build was green, so I don't think we'll have to wait for CI to do another run 😅

@thaJeztah thaJeztah merged commit 28f62c5 into moby:master Feb 26, 2020
@thaJeztah thaJeztah deleted the revert_jenkinsfile_pin_older_windows branch February 26, 2020 12:09
@thaJeztah thaJeztah mentioned this pull request Feb 26, 2020
Merged
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/testing process/cherry-picked status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @StefanScherer @AkihiroSuda