Skip to content

Jenkinsfile: temporarily pin windows image to 10.0.17763.973#40506

Merged
tiborvass merged 1 commit intomoby:masterfrom
thaJeztah:jenkinsfile_pin_older_windows
Feb 12, 2020
Merged

Jenkinsfile: temporarily pin windows image to 10.0.17763.973#40506
tiborvass merged 1 commit intomoby:masterfrom
thaJeztah:jenkinsfile_pin_older_windows

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

The latest ltsc2019 image (10.0.17763.1039) appear to be broken,
and even a RUN Write-Host hello hangs.

Temporarily switching back to an older version so that CI doesn't fail.

The latest `ltsc2019` image (`10.0.17763.1039`) appear to be broken,
and even a `RUN Write-Host hello` hangs.

Temporarily switching back to an older version so that CI doesn't fail.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Copy Markdown
Member Author

Windows stage looks to be green with this change @StefanScherer

(linux failure is a flaky test)

Copy link
Copy Markdown
Contributor

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanScherer
Copy link
Copy Markdown
Contributor

StefanScherer commented Feb 12, 2020

Let's go with the previous tag, CI to rebuild the VM images is in progress taking longer due to some GitHub org refactorings.

@thaJeztah thaJeztah marked this pull request as ready for review February 12, 2020 16:28
@thaJeztah
Copy link
Copy Markdown
Member Author

moved it out of draft, and kicked CI again to see if the Linux stage goes green (but any changes in Linux should be unrelated)

@cpuguy83
Copy link
Copy Markdown
Member

Let's go with the previous tag, CI to rebuild the VM images is in progress due to some GitHub org refactorings.

@StefanScherer Do you mean we shouldn't merge this?

@thaJeztah
Copy link
Copy Markdown
Member Author

@cpuguy83 no (discussed on slack); @StefanScherer was working on updating the workers and see if that would resolve the issue, but this is taking longer, so in the meantime downgrading the image ("previous tag") works.

After this is merged, I'll prepare a draft "revert" PR so that we can test once the upgraded workers are available

Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sure, I believe you 😄

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

Oh sure, I believe you 😄

passed-the-test

@tiborvass tiborvass merged commit acb236d into moby:master Feb 12, 2020
@thaJeztah thaJeztah deleted the jenkinsfile_pin_older_windows branch February 12, 2020 17:36
@StefanScherer
Copy link
Copy Markdown
Contributor

ping @thaJeztah we can revert this temporary fix, the windows-2019 Jenkins agents are updated to 10.0.17763.1039, and running containers now works with the latest servercore image which I have tested in our canaries environment.

@thaJeztah
Copy link
Copy Markdown
Member Author

Perfect, opened #40512

@thaJeztah
Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants