Use build args to override binary commits in dockerfile#39919
Use build args to override binary commits in dockerfile#39919thaJeztah merged 1 commit intomoby:masterfrom
Conversation
bf3b8e2 to
d6123cd
Compare
160d903 to
dfc3fe4
Compare
dfc3fe4 to
6c67656
Compare
|
Not really sure I understand the reasoning behind this change. |
I can't really speak to the reasoning behind it as I just picked an issue randomly, @thaJeztah ? |
6c67656 to
239fa20
Compare
|
We discussed this in the maintainers meeting, and this changes looks good; it looks like it needs a rebase though; could you rebase the PR? If you need a hand, I'm happy to do so for you |
Signed-off-by: Justen Martin <jmart@the-coder.com>
239fa20 to
095ca77
Compare
|
@thaJeztah thanks for following up, I went ahead and rebased. Everything should be in order, but I'd appreciate if you made a pass at it. |
|
Thanks! We'll likely be doing some follow-ups, and make the Dockerfile the "canonical" place to put the versions, but there may still be some discussion around the preferred approach for that; we didn't want you to have to wait for that (and having to rebase your PR each time), so we want to go ahead with this PR, as it's a first step towards that goal 👍 |
|
All green 👍 💚 |
Signed-off-by: Justen Martin jmart@the-coder.com
closes #36412
- What I did
modified dockerfile to allow the overriding of binary commits through build args
- How I did it
added
ARGdirectives to appropriate build stages in dockerfile and updated corresponding install scripts to override env variables when build arg is provided- How to verify it
--build-argflag and confirm through the build output that the correct value was used- Description for the changelog
Several new build arguments were added to override binary commits in order to specify specific versions for testing
- A picture of a cute animal (not mandatory but encouraged)
