@carlosedp you inadvertently added the dockerd binary in the PR.

My bad, it fell into the cracks together with all the files. Should be removed now.

@carlosedp the vendor check failed, you've got to vendor this way:

$ make BIND_DIR=. shell
# vndr

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "riscv64" git@github.com:carlosedp/moby.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354512336
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Codecov Report

❗ No coverage uploaded for pull request base (master@e105a74). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #39423   +/-   ##
=========================================
  Coverage          ?   37.33%           
=========================================
  Files             ?      609           
  Lines             ?    45197           
  Branches          ?        0           
=========================================
  Hits              ?    16875           
  Misses            ?    26034           
  Partials          ?     2288

@tiborvass Why when I deleted whole vendor dir and ran vndr it didn't do the correct thing?

When I ran inside the shell, the difference was that some go.mod files were deleted.

@carlosedp probably vndr version differences, that's why we pin the vndr version in the dockerfile so that everyone agrees on how to vendor.

reminds me that we need to debug why updating to the latest vndr version causes CI to fail; #39216

oh; before we merge this one, could we merge #39054 ? in case we want to backport that one (without introducing the new things from the other bumps)

we also might want to ask if they can tag a new version for netlink

Let's also get #39216 first, it includes a vndr that has riscv64 support (LK4D4/vndr#80) I can rebase this PR then.

@carlosedp I updated your PR. One notable difference is that the netns commit was 13995c7128ccc8e51e9a6bd2b551020a27180abd which didn't include the riscv changes from vishvananda/netns#34. So I updated it to 7109fa855b0ff1ebef7fbd2f6aa613e8db7cfbc0.

Amazing. Thanks @tiborvass. Now the vndr I used standalone would work fine since the CI have been updated as well right?

@carlosedp most likely, but I'd still recommend using make BIND_DIR=. shell just in case. Either way, the vendor CI will catch any mismatches.

For the record, I couldn't figure out this: #39423 (comment)

After updating libnetwork it failed building. I saw the latest libnetwork update required a new sctp too.

Ugh, forgot to include moby/libnetwork#2412 so I updated libnetwork as well.

vendor check is failing @tiborvass

@thaJeztah what are you talking about? 👀 😛jk updated

LGTM