Skip to content

bump vndr to f5ab8fc5f, and revendor#39216

Merged
tiborvass merged 1 commit intomoby:masterfrom
thaJeztah:bump_vndr
Jun 29, 2019
Merged

bump vndr to f5ab8fc5f, and revendor#39216
tiborvass merged 1 commit intomoby:masterfrom
thaJeztah:bump_vndr

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented May 14, 2019

The latest version of vndr preserves go.mod in vendored dependencies, which makes it easier to check if other dependencies need to be updated as well

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah requested a review from tianon as a code owner May 14, 2019 22:28
@AkihiroSuda
Copy link
Member

AkihiroSuda commented May 15, 2019 

22:42:11 The result of vndr differs
22:42:11 
22:42:11  M vendor/github.com/moby/buildkit/go.mod
22:42:11 
22:42:11 Please vendor your package with github.com/LK4D4/vndr.

@thaJeztah
Copy link
Member Author

thaJeztah commented May 15, 2019

hm interesting; let me try running it again

@codecov
Copy link

codecov bot commented May 17, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@70f67c6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #39216   +/-   ##
=========================================
  Coverage          ?   37.32%           
=========================================
  Files             ?      609           
  Lines             ?    45197           
  Branches          ?        0           
=========================================
  Hits              ?    16868           
  Misses            ?    26040           
  Partials          ?     2289

@dperny dperny mentioned this pull request May 17, 2019
Merged
@thaJeztah
Copy link
Member Author

thaJeztah commented May 17, 2019

I have no idea why vendor check is failing; I ran vndr again, but it gave no changes on my machine, but vendor is still failing;

16:48:24 2019/05/17 16:48:24 Running time: 1m29.172936525s
16:48:24 The result of vndr differs
16:48:24 
16:48:24  M vendor/github.com/moby/buildkit/go.mod
16:48:24 
16:48:24 Please vendor your package with github.com/LK4D4/vndr.

It shows M though (modified), so wondering if it's a newline issue, or perhaps whitespace? weird.

@thaJeztah thaJeztah mentioned this pull request Jun 26, 2019
Merged
@tiborvass tiborvass changed the title bump vndr to v0.0.3, and revendor bump vndr to f5ab8fc5f, and revendor Jun 27, 2019
@thaJeztah
bump vndr to f5ab8fc5f, and revendor
0a3c9b9 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@tiborvass
Copy link
Contributor

tiborvass commented Jun 28, 2019

@thaJeztah I think it just needs a rebase. Hopefully this time it's good!

@tiborvass
Copy link
Contributor

tiborvass commented Jun 28, 2019

For the record I changed vndr to f5ab8fc5f to include LK4D4/vndr#80

@tiborvass tiborvass merged commit e105a74 into moby:master Jun 29, 2019
@thaJeztah thaJeztah deleted the bump_vndr branch June 29, 2019 18:38
This was referenced Aug 8, 2019
Merged
Merged
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@tianon tianon Awaiting requested review from tianon tianon is a code owner

Assignees

@tonistiigi tonistiigi

Labels

status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

6 participants

@thaJeztah @AkihiroSuda @tiborvass @tonistiigi @yongtang @GordonTheTurtle