Skip to content

Bump buildkit v0.5.0#39152

Merged
tiborvass merged 7 commits intomoby:masterfrom
thaJeztah:bump_buildkit
May 10, 2019
Merged

Bump buildkit v0.5.0#39152
tiborvass merged 7 commits intomoby:masterfrom
thaJeztah:bump_buildkit

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Apr 27, 2019 •
edited
Loading

release notes: https://github.com/moby/buildkit/releases/tag/v0.5.0

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Apr 27, 2019

ping @tonistiigi @AkihiroSuda ptal

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Apr 27, 2019

Ah, dang; need to make some changes

22:35:14 Congratulations!  All commits are properly signed with the DCO!
22:36:14 builder/builder-next/adapters/snapshot/snapshot.go:53:34:warning: cannot use &(snapshotter literal) (value of type *snapshotter) as snapshot.SnapshotterBase value in variable declaration: missing method Name (gosimple)
22:36:14 builder/builder-next/adapters/snapshot/snapshot.go:74:9:warning: cannot use s (variable of type *snapshotter) as snapshot.SnapshotterBase value in return statement: missing method Name (unconvert)
22:36:14 builder/builder-next/adapters/snapshot/snapshot.go:53:34:warning: cannot use &(snapshotter literal) (value of type *snapshotter) as snapshot.SnapshotterBase value in variable declaration: missing method Name (unconvert)
22:36:15 Build step 'Execute shell' marked build as failure

@thaJeztah
bump buildkit v0.5.0
3e4723c 
full diff: moby/buildkit@8818c67...v0.5.0

- moby/buildkit#909 exporter: support unpack opt for image exporter
- moby/buildkit#961 dockerfile: allow subdirs for remote contexts

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
bump containerd/continuity aaeac12a7ffcd198ae25440a9dff125c2e2703a7
447cbff 
- containerd/continuity#140 Fix directory comparison in changes

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
bump containerd 3a3f0aac8819165839a41fee77a4f4ac8b103097
25e6487 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
bump containerd/console 0650fd9eeb50bab4fc99dceb9f2e14cf58f36e7f
3d7d8a5 
full diff: containerd/console@c12b1e7...0650fd9

- containerd/console#30 Add common project repo checks/README references

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
bump gogo/protobuf v1.2.1
647f31b 
full diff: gogo/protobuf@v1.2.0...v1.2.1

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
bump gogo/googleapis v1.2.0
5d51ac5 
full diff: gogo/googleapis@08a7655...v1.2.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
bump golang.org/x/crypto 88737f569e3a9c7ab309cdc09a07fe7fc87233c3
d6d2b30 
no local changes, just syncing with containerd

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah requested a review from tonistiigi as a code owner April 27, 2019 23:05
thaJeztah
thaJeztah commented Apr 27, 2019
View reviewed changes
Comment thread builder/builder-next/adapters/snapshot/snapshot.go
}

func (s *snapshotter) Name() string {
return "default"
Copy link
Copy Markdown
Member Author

@thaJeztah thaJeztah Apr 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't entirely sure where the name is used, and what to name this one, so let me know what I should use here

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonistiigi WDYT? moby seems more consistent?

Copy link
Copy Markdown
Member

@tonistiigi tonistiigi May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not used anywhere in moby so doesn't matter much. I'm fine with either.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@32daacb). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #39152   +/-   ##
=========================================
  Coverage          ?   37.03%           
=========================================
  Files             ?      612           
  Lines             ?    45411           
  Branches          ?        0           
=========================================
  Hits              ?    16816           
  Misses            ?    26310           
  Partials          ?     2285

@tonistiigi
Copy link
Copy Markdown
Member

tonistiigi commented May 7, 2019

buildkit changes LGTM, don't know about the containerd/proto parts

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented May 8, 2019

LGTM

@tiborvass tiborvass merged commit df43bc3 into moby:master May 10, 2019
@thaJeztah thaJeztah deleted the bump_buildkit branch May 10, 2019 23:57
@thaJeztah thaJeztah mentioned this pull request May 14, 2019
Merged
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda left review comments

@tiborvass tiborvass tiborvass approved these changes

@tonistiigi tonistiigi Awaiting requested review from tonistiigi tonistiigi is a code owner

Assignees

No one assigned

Labels

area/builder Build area/runtime Runtime status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

6 participants

@thaJeztah @tonistiigi @dmcgowan @tiborvass @AkihiroSuda @GordonTheTurtle