dockerfile: allow subdirs for remote contexts#961
Merged
tonistiigi merged 1 commit intomoby:masterfrom Apr 26, 2019
Merged
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tiborvass
approved these changes
Apr 26, 2019
ijc
approved these changes
Apr 26, 2019
ijc
left a comment
There was a problem hiding this comment.
This should work for ~any remote (including git), right?
Member
Author
|
@ijc . Git, yes. But not for local files. |
|
Ack, for local files (llb.Local) that's a client side |
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Apr 27, 2019
full diff: moby/buildkit@8818c67...v0.5.0 - moby/buildkit#909 exporter: support unpack opt for image exporter - moby/buildkit#961 dockerfile: allow subdirs for remote contexts Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
May 11, 2019
full diff: moby/buildkit@8818c67...v0.5.0 - moby/buildkit#909 exporter: support unpack opt for image exporter - moby/buildkit#961 dockerfile: allow subdirs for remote contexts Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 3e4723cf3395dcdaa4c98acba549ac0170899504 Component: engine
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
May 14, 2019
full diff: moby/buildkit@8818c67...v0.5.0 - moby/buildkit#909 exporter: support unpack opt for image exporter - moby/buildkit#961 dockerfile: allow subdirs for remote contexts Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 3e4723c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
May 14, 2019
full diff: moby/buildkit@8818c67...v0.5.0 - moby/buildkit#909 exporter: support unpack opt for image exporter - moby/buildkit#961 dockerfile: allow subdirs for remote contexts Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 3e4723cf3395dcdaa4c98acba549ac0170899504) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: ea090084234de4776289445b6e648622d874c49a Component: engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow specifying a subdir when building from a remote context. For example, if building from tarball that contains multiple projects.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com