Skip to content

Update API version to v1.40#38089

Merged
thaJeztah merged 3 commits intomoby:masterfrom
thaJeztah:fix_api_version
Oct 27, 2018
Merged

Update API version to v1.40#38089
thaJeztah merged 3 commits intomoby:masterfrom
thaJeztah:fix_api_version

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Oct 26, 2018

Some features were merged after API v1.39 shipped as part of the Docker 18.09 betas; this PR updates the API version to 1.40, and corrects the minimal API version for those features.

- Description for the changelog

+ Update API version to 1.40 [moby/moby#38089](https://github.com/moby/moby/pull/38089)

- A picture of a cute animal (not mandatory but encouraged)

cute_owl_by_helmuttt-dahymkr

image: "Cute Owl by HELMUTTT"

@thaJeztah
Update API version to v1.40
e238713 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Move support for sysctl options in services to API v1.40
cb9d2cb 
This feature was added in 14da20f,
and was merged after API v1.39 shipped as part of the Docker 18.09
release candidates.

This commit moves the feature to the correct API version.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Move support for filtering on node labels to API v1.40
c20aa78 
This feature was added in 514ce73,
and was merged after API v1.39 shipped as part of the Docker 18.09

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah requested a review from vdemeester as a code owner October 26, 2018 14:01
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Oct 26, 2018

ping @AkihiroSuda (sorry, this will conflict with #38003) @vdemeester

vdemeester
vdemeester approved these changes Oct 26, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@olljanat olljanat mentioned this pull request Oct 26, 2018
Merged
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Oct 26, 2018

Windows RS5 seems to be really broken;

14:05:08 INFO: Docker images of the daemon under test
14:05:08 
14:05:08 REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
14:05:08 
14:05:08 INFO: Base image for tests is microsoft/windowsservercore
14:05:08 INFO: Loading windowsservercore .tar from disk into the daemon under test. This may take some time...
14:06:50 
14:06:50 
14:06:50 ERROR: Failed 'ERROR: Failed to load c:\baseimages\windowsservercore.tar into daemon under test' at 10/26/2018 14:06:50
14:06:50 At C:\gopath\src\github.com\docker\docker\hack\ci\windows.ps1:705 char:21
14:06:50 + ...             Throw $("ERROR: Failed to load $readBaseFrom`:\baseimages ...
14:06:50 +                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
14:06:50

yongtang
yongtang approved these changes Oct 26, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Oct 27, 2018

yeah, let's merge; the RS5 issue is definitely not related

@thaJeztah thaJeztah merged commit b8e87cf into moby:master Oct 27, 2018
@thaJeztah thaJeztah deleted the fix_api_version branch October 27, 2018 01:01
@thaJeztah thaJeztah mentioned this pull request Apr 30, 2020
Closed
@3socha 3socha mentioned this pull request May 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

+2 more reviewers

@vdemeester vdemeester vdemeester approved these changes

@yongtang yongtang yongtang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/api API impact/api impact/changelog status/4-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah @vdemeester @yongtang @AkihiroSuda @GordonTheTurtle