LGTM once janky is 💚

Thanks! Looks like we need some changes to make the new filter work;

• update newListNodesFilters() to accept the new filter

  moby/daemon/cluster/filters.go

  Lines 12 to 46 in 3a633a7

  	func newListNodesFilters(filter filters.Args) (*swarmapi.ListNodesRequest_Filters, error) {
  	accepted := map[string]bool{
  	"name": true,
  	"id": true,
  	"label": true,
  	"role": true,
  	"membership": true,
  	}
  	if err := filter.Validate(accepted); err != nil {
  	return nil, err
  	}
  	f := &swarmapi.ListNodesRequest_Filters{
  	NamePrefixes: filter.Get("name"),
  	IDPrefixes: filter.Get("id"),
  	Labels: runconfigopts.ConvertKVStringsToMap(filter.Get("label")),
  	}
  	for _, r := range filter.Get("role") {
  	if role, ok := swarmapi.NodeRole_value[strings.ToUpper(r)]; ok {
  	f.Roles = append(f.Roles, swarmapi.NodeRole(role))
  	} else if r != "" {
  	return nil, fmt.Errorf("Invalid role filter: '%s'", r)
  	}
  	}
  	for _, a := range filter.Get("membership") {
  	if membership, ok := swarmapi.NodeSpec_Membership_value[strings.ToUpper(a)]; ok {
  	f.Memberships = append(f.Memberships, swarmapi.NodeSpec_Membership(membership))
  	} else if a != "" {
  	return nil, fmt.Errorf("Invalid membership filter: '%s'", a)
  	}
  	}
  	return f, nil
  	}

• update the Swagger file to document the newly accepted filter; https://github.com/moby/moby/blob/bd06a5ea4df919ff323510fba10801b5673a3af6/api/swagger.yaml?utf8=✓#L8577-L8589
• add a note to the API changelog to mention the new filter; https://github.com/moby/moby/blob/master/docs/api/version-history.md. This change will be in API 1.39, so either a new entry should be added for that version, or that would come with #37472 (once merged)

LGTM, thanks!

LGTM

ignore the z error:

curl: (56) SSL read: error:00000000:lib(0):func(0):reason(0), errno 104

because z infrastructure issues