Skip to content

Bump to RS3 final build, and remove LCOW_SUPPORTED#36065

Merged
AkihiroSuda merged 1 commit intomoby:masterfrom
microsoft:jjh/bumprs3andlcowsupported
Jan 20, 2018
Merged

Bump to RS3 final build, and remove LCOW_SUPPORTED#36065
AkihiroSuda merged 1 commit intomoby:masterfrom
microsoft:jjh/bumprs3andlcowsupported

Conversation

@lowenna
Copy link
Member

@lowenna lowenna commented Jan 19, 2018

Signed-off-by: John Howard jhoward@microsoft.com

Fixes a long-standing todo now the image store re-coalescing PR has been merged. No need for the environment variable to determine if LCOW is supported any more, just experimental. At the same time, it bumps the minimum requirement to RS3 RTM build (16299)

@johnstep PTAL.

Signed-off-by: John Howard <jhoward@microsoft.com>
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@AkihiroSuda AkihiroSuda merged commit ef3f7d1 into moby:master Jan 20, 2018
rn added a commit to rn/lcow that referenced this pull request Jan 21, 2018
With:
- moby/moby#36065
- moby/moby#34859
merged there is no need for environment variables anymore

Update instructions.

Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
@rn rn mentioned this pull request Jan 21, 2018
rn added a commit to rn/lcow that referenced this pull request Jan 21, 2018
With:
- moby/moby#36065
- moby/moby#34859
merged there is no need for environment variables anymore

Update instructions.

Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
rn added a commit to rn/lcow that referenced this pull request Jan 21, 2018
With:
- moby/moby#36065
- moby/moby#34859
merged there is no need for environment variables anymore

Update instructions.

Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
@lowenna lowenna deleted the jjh/bumprs3andlcowsupported branch January 22, 2018 16:22
@thaJeztah thaJeztah added the area/lcow Issues and PR's related to the experimental LCOW feature label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants