Merged
Conversation
Commit 3ba1dda bumped the API version, but forgot to actually bump the version in code. This patch fixes the version to match those changes :-) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
318e8ff to
7f8dbe4
Compare
Contributor
|
LGTM |
dnephin
approved these changes
Nov 2, 2017
Member
dnephin
left a comment
There was a problem hiding this comment.
I guess you missed #35343 (review) :)
Member
Author
Wow, I definitely did; saw the LGTM, but the commend 😂 |
Contributor
|
I think it should be merged ASAP as the other parts of the v1.35 move are already merged (both doc, and API changes) |
Member
Author
|
YOLO let's merge this, because it's blocking some other PR's 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 3ba1dda (#35343) bumped the API version, but forgot to actually bump the version in code.
This patch fixes the version to match those changes :-)
thanks @simonferquel for spotting this; I messed that one up 😅