Skip to content

Bump API version to 1.35#35343

Merged
yongtang merged 1 commit intomoby:masterfrom
thaJeztah:bump-api-version-1.35
Oct 31, 2017
Merged

Bump API version to 1.35#35343
yongtang merged 1 commit intomoby:masterfrom
thaJeztah:bump-api-version-1.35

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Oct 31, 2017 •
edited
Loading

- Description for the changelog

* Bump API version to v1.35 [moby/moby#35343](https://github.com/moby/moby/pull/35343)

ping @dnephin @vdemeester

@thaJeztah
Bump API version to 1.35
ba6b5aa 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vdemeester
vdemeester approved these changes Oct 31, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

dnephin
dnephin approved these changes Oct 31, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dnephin
dnephin reviewed Oct 31, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a constant in the code as well?

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Oct 31, 2017

experimental is failing on DockerSwarmSuite.TestSwarmLockUnlockCluster #34051

z is failing on TestExecTTY, which was flaky once #18544, but should've been addressed by #21018;

12:29:28 
12:29:28 ----------------------------------------------------------------------
12:29:28 FAIL: docker_cli_exec_unix_test.go:43: DockerSuite.TestExecTTY
12:29:28 
12:29:28 docker_cli_exec_unix_test.go:69:
12:29:28     c.Assert(bytes.Contains(buf, []byte("hello")), checker.Equals, true, check.Commentf(string(buf[:read])))
12:29:28 ... obtained bool = false
12:29:28 ... expected bool = true
12:29:28 ... cat /foo && exit

12:29:28 / # 
12:29:28 
12:29:29

@yongtang yongtang merged commit 3ba1dda into moby:master Oct 31, 2017
@thaJeztah thaJeztah deleted the bump-api-version-1.35 branch October 31, 2017 19:38
@thaJeztah thaJeztah mentioned this pull request Nov 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dnephin dnephin dnephin approved these changes

@vdemeester vdemeester vdemeester approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/api API impact/api impact/changelog status/4-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah @vdemeester @dnephin @yongtang @GordonTheTurtle