Fix race condition when exec with tty#21018
Merged
calavera merged 2 commits intomoby:masterfrom Mar 10, 2016
Merged
Conversation
I can reproduce this easily on one of my servers, `docker exec -ti my_cont ls` will not print anything, without `-t` it acts normally. Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
It'll weaken this test case, and the flaky test is resolved by another commit in this PR. Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
Contributor
|
We have discussed this f2f, I think this can fix our issue. so LGTM |
Contributor
|
Isn't this missing a |
Contributor
|
@mlaventure I think wg is passed from Run, and there is Wait there. |
Contributor
|
correct, I didn't trace the code properly, my bad. Passed down from |
Contributor
Author
|
ping @vbatts @thaJeztah since it'll fix #18544 |
Contributor
|
LGTM |
calavera
added a commit
that referenced
this pull request
Mar 10, 2016
Fix race condition when exec with tty
runcom
pushed a commit
to runcom/docker
that referenced
this pull request
Jul 12, 2016
Upstream reference: moby#21018 I can reproduce this easily on one of my servers, `docker exec -ti my_cont ls` will not print anything, without `-t` it acts normally. Signed-off-by: Qiang Huang <h.huangqiang@huawei.com> Signed-off-by: Antonio Murdaca <runcom@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can reproduce this easily on one of my servers,
docker exec -ti my_cont lswill not print anything, without-tit acts normally.It also revert hack in TestExecTTY, I think this PR can fix #18544