Fix volume inspect with empty ID#34770
Merged
yongtang merged 1 commit intomoby:masterfrom Sep 11, 2017
Merged
Conversation
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Contributor
|
LGTM ping @tiborvass @vdemeester |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a problem found here: docker-archive/docker-ce#221 (comment)
Related to a fix: #34487
Using
path.Join()strips trailing/, which causes theVolumeInspectcall to hit the volume list url. Since volume list returns a json object there is no error and VolumeInspect returns an empty object.