Fix requests for docker host ending with slash#34487
Merged
vieux merged 1 commit intomoby:masterfrom Aug 14, 2017
Merged
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
dnephin
reviewed
Aug 11, 2017
Member
dnephin
left a comment
There was a problem hiding this comment.
change looks good, should be easy to unit test as well
|
LGTM |
Member
|
do we want a test added? |
Member
|
changed "fixes" to "relates to", because this needs to be vendored into docker/cli before it actually fixes the issue 😄 ping @dnephin for merging (we weren't sure if you wanted a unit test as part of this PR) |
Member
|
It seems like it would be easy to add in this PR, but if we need to merge this for some deadline I guess a follow up is fine too. |
Contributor
|
LGTM @tonistiigi can you open the pr in docker/cli? |
This was referenced Sep 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to docker-library/docker#71
DOCKER_HOSTending with/would cause the first component of a request to be skipped. Resulting invalidpingresults and skipping manually set version.@dnephin @thaJeztah
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com