update to github.com/sirupsen/logrus v1.0.0#33998
Closed
mcandre wants to merge 1 commit intomoby:masterfrom
mcandre:update-logrus
Closed
update to github.com/sirupsen/logrus v1.0.0#33998mcandre wants to merge 1 commit intomoby:masterfrom mcandre:update-logrus
mcandre wants to merge 1 commit intomoby:masterfrom
mcandre:update-logrus
Conversation
|
Please sign your commits following these rules: $ git clone -b "update-logrus" git@github.com:mcandre/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Andrew Pennebaker <apennebaker@datapipe.com>
Author
|
Looks like logrus casing needs to be fixed in moby's dependencies' source as well. Opened a pull request to fix containerd: containerd/containerd#1136 |
Contributor
|
Yes @stevvooe was looking at doing a coordinated case change for logrus. |
Author
|
Looks like some of these CI builds are failing due to yaml.h (libyaml?) not being installed |
Contributor
|
Microsoft/hcsshim v0.6.1 contains the changed logrus casing. |
Member
|
@mcandre containerd has been merged. You might need to update the 0.2.x branch as well though. |
5 tasks
Member
|
Can we close this PR and adopt #34272 ? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some broken dependencies by using latest github.com/sirupsen/logrus.