Update grpc to v1.3.0 and bump protobuf bindings.#33590
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jun 9, 2017
Merged
Update grpc to v1.3.0 and bump protobuf bindings.#33590thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
and update some dependent packages. We would like to keep moby/moby and swarmkit somewhat in sync here and moby/swarmkit#2229 proposes a similar bump to swarmkit, needed due to moby/swarmkit#1965 which pulls in containerd which uses some newer features of the grpc package. Signed-off-by: Ian Campbell <ian.campbell@docker.com>
|
Looks like something went wrong with CI, but it's not clear to me whether it had anything to do with these changes. I'll rerun CI. |
|
LGTM |
lelenanam
added a commit
to lelenanam/DockerCuties
that referenced
this pull request
Jun 9, 2017
Example: moby/moby#33590 link: "https://upload.wikimedia.org/wikipedia/commons/thumb/f/fb/Swans_warsaw_10_12_2010_poland_m_kutera.jpg/640px-Swans_warsaw_10_12_2010_poland_m_kutera.jpg "Swans"" Signed-off-by: Elena Morozova <lelenanam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and update some dependent packages.
We would like to keep moby/moby and swarmkit somewhat in sync here and
moby/swarmkit#2229 proposes a similar bump to
swarmkit, needed due to moby/swarmkit#1965 which
pulls in containerd which uses some newer features of the grpc package.
Signed-off-by: Ian Campbell ian.campbell@docker.com
- What I did
Updated the grpc and protobuf go bindings to correspond to a similar change in moby/swarmkit#2229, primarily to update
google.golang.org/grpcfromv1.0.4tov1.3.0. Updatedgolang.org/x/netandgoogle.golang.org/genprotoas a consequence.I'm raising this PR because AIUI there is a desire to have swarmkit and engine be reasonably in sync with each other wrt grpc versions. Probably this should wait to be merged after the swarmkit change is merged, and possibly this should only be merged alongside (or, better, as part of) a future swarmkit vendor bump. In the meantime getting some CI cycles on the grpc update alone seems useful.
- How I did it
Edited
vendor.confand reranvndr, followed by being pleasantly surprised that no real code changes appeared to be needed.- How to verify it
I ran the tests (
make shellthen./hack/make.sh binary test-unit test-integration-cli test-docker-py).- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)