Skip to content

*: use opencontainers/go-digest package#29963

Merged
aaronlehmann merged 2 commits intomoby:masterfrom
stevvooe:use-digest-package
Jan 7, 2017
Merged

*: use opencontainers/go-digest package#29963
aaronlehmann merged 2 commits intomoby:masterfrom
stevvooe:use-digest-package

Conversation

@stevvooe
Copy link
Copy Markdown
Contributor

@stevvooe stevvooe commented Jan 7, 2017

The digest data type, used throughout docker for image verification
and identity, has been broken out into opencontainers/go-digest. This
PR updates the dependencies and moves uses over to the new type.

Signed-off-by: Stephen J Day stephen.day@docker.com

@stevvooe stevvooe added this to the 1.14.0 milestone Jan 7, 2017
@aaronlehmann
Copy link
Copy Markdown

There seems to be a vendoring issue

01:30:21 reference/reference.go:10:2: cannot find package "github.com/opencontainers/go-digest" in any of:
01:30:21 	/go/src/github.com/docker/docker/vendor/github.com/opencontainers/go-digest (vendor tree)
01:30:21 	/usr/local/go/src/github.com/opencontainers/go-digest (from $GOROOT)
01:30:21 	/go/src/github.com/opencontainers/go-digest (from $GOPATH)

@stevvooe
Copy link
Copy Markdown
Contributor Author

stevvooe commented Jan 7, 2017

@aaronlehmann There is a subsequent commit on its way.

@stevvooe stevvooe force-pushed the use-digest-package branch 3 times, most recently from d7c9cd4 to 4a10108 Compare January 7, 2017 01:47
@LK4D4
Copy link
Copy Markdown
Contributor

LK4D4 commented Jan 7, 2017

@stevvooe windows compilation failed :/

@stevvooe stevvooe force-pushed the use-digest-package branch from 4a10108 to de0d90e Compare January 7, 2017 01:52
@stevvooe
Copy link
Copy Markdown
Contributor Author

stevvooe commented Jan 7, 2017

@LK4D4 Still hunting down some stuff.

@stevvooe stevvooe force-pushed the use-digest-package branch 2 times, most recently from 436766f to d2b3cf1 Compare January 7, 2017 02:33
The `digest` data type, used throughout docker for image verification
and identity, has been broken out into `opencontainers/go-digest`. This
PR updates the dependencies and moves uses over to the new type.

Signed-off-by: Stephen J Day <stephen.day@docker.com>
Signed-off-by: Stephen J Day <stephen.day@docker.com>
@stevvooe stevvooe force-pushed the use-digest-package branch from d2b3cf1 to 083ad52 Compare January 7, 2017 02:49
Children map[string]*bintree
}

var _bintree = &bintree{nil, map[string]*bintree{
Copy link
Copy Markdown
Contributor

@justincormack justincormack Jan 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These whitespace changes seem unrelated...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a result of calling gofmt -s.

Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

Copy link
Copy Markdown

@aaronlehmann aaronlehmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronlehmann aaronlehmann merged commit 7c62f58 into moby:master Jan 7, 2017
@thaJeztah
Copy link
Copy Markdown
Member

late to the party, but LGTM, thanks!

@stevvooe stevvooe deleted the use-digest-package branch January 9, 2017 19:39
kolyshkin pushed a commit to kolyshkin/moby that referenced this pull request May 1, 2020
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
(cherry picked from commit bd33a99)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

Conflicts:
 - daemon/prune.go: missing moby#29226,
   moby#29963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants