Cherry-pick : Fixing a couple of network plugin life-cycle mgmt issues#29858
Merged
tiborvass merged 4 commits intomoby:1.13.xfrom Jan 4, 2017
Merged
Cherry-pick : Fixing a couple of network plugin life-cycle mgmt issues#29858tiborvass merged 4 commits intomoby:1.13.xfrom
tiborvass merged 4 commits intomoby:1.13.xfrom
Conversation
Contributor
|
@mavenugo doesn't compile |
Contributor
Author
The current GetAll handles both V2 and legacy plugins. Also due to the nature of V1 plugins, it also loads them. This causes problems when loading is not required. Hence adding an independent API that will return only the plugins that are loaded using v2 mangaed plugins. Signed-off-by: Madhu Venugopal <madhu@docker.com>
Signed-off-by: Madhu Venugopal <madhu@docker.com>
Signed-off-by: Madhu Venugopal <madhu@docker.com>
Signed-off-by: Madhu Venugopal <madhu@docker.com>
a297a4a to
c5b5b4e
Compare
Contributor
|
@mavenugo windows error related ? |
Contributor
|
ping @tiborvass LGTM |
Contributor
|
LGTM |
Member
Contributor
Author
|
@thaJeztah the cherry-pick for 1.13.0 branch in docker must come from libnetwork v0.9 branch and yes, by the time this vendoring happened we got 1 additional patch from #29891 which fixes #28836. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picking #29556