Add a GetAll function that returns only managed plugins supported by V2#29665
Merged
anusha-ragunathan merged 1 commit intomoby:masterfrom Dec 22, 2016
Merged
Add a GetAll function that returns only managed plugins supported by V2#29665anusha-ragunathan merged 1 commit intomoby:masterfrom
anusha-ragunathan merged 1 commit intomoby:masterfrom
Conversation
The current GetAll handles both V2 and legacy plugins. Also due to the nature of V1 plugins, it also loads them. This causes problems when loading is not required. Hence adding an independent API that will return only the plugins that are loaded using v2 mangaed plugins. Signed-off-by: Madhu Venugopal <madhu@docker.com>
|
|
||
| // GetAllManagedPluginsByCap returns a list of managed plugins matching the given capability. | ||
| func (ps *Store) GetAllManagedPluginsByCap(capability string) []plugingetter.CompatPlugin { | ||
| return ps.getAllByCap(capability) |
Contributor
Author
There was a problem hiding this comment.
getAllByCap already locks it. I dont think it is required to lock it again here.
Contributor
|
LGTM |
mavenugo
added a commit
to mavenugo/libnetwork
that referenced
this pull request
Dec 22, 2016
Read this for more details : moby/moby#29665 Signed-off-by: Madhu Venugopal <madhu@docker.com>
mavenugo
added a commit
to mavenugo/libnetwork
that referenced
this pull request
Dec 22, 2016
Read this for more details : moby/moby#29665 Signed-off-by: Madhu Venugopal <madhu@docker.com>
mavenugo
added a commit
to mavenugo/libnetwork
that referenced
this pull request
Jan 4, 2017
Read this for more details : moby/moby#29665 Signed-off-by: Madhu Venugopal <madhu@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current GetAllByCap API handles both V2 and legacy plugins. Also due to the
nature of V1 plugins, it also loads them. This causes problems when
loading is not required. Hence adding an independent API that will
return only the plugins that are loaded using v2 mangaed plugins.
Based on discussions with @anusha-ragunathan, This patch is required to properly fix the IT failures in #29556.
Signed-off-by: Madhu Venugopal madhu@docker.com