Merged
Conversation
Contributor
|
@creack I'm going to assign to you reviews for registry client. |
Contributor
|
Thanks! |
liusdu
pushed a commit
to liusdu/moby
that referenced
this pull request
Oct 30, 2017
Fix race between sandbox.delete() and SetKey() When sandbox is deleting, another Setkey routine could be also in progress as there's no lock to protect it. So add a inDelete check for SetKey() to eliminate the race. Fixes moby#286 Signed-off-by: Zhang Wei <zhangwei555@huawei.com> See merge request docker/docker!497
thaJeztah
pushed a commit
to thaJeztah/docker
that referenced
this pull request
Jun 20, 2019
[18.09 backport] Fix docker cp when container source path is /
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #285. The whole registry client needs a refactor, but here's a quick fix for more leaking fds.